Summary: | [NEW PORT] devel/py-pystaticconfiguration: Validating and reading configuration from heterogeneous formats | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | James Elstone <james> |
Component: | Individual Port(s) | Assignee: | Tobias Kortkamp <tobik> |
Status: | Closed Feedback Timeout | ||
Severity: | Affects Some People | CC: | james, koobs, miwi, python |
Priority: | --- | Keywords: | feature |
Version: | Latest | Flags: | james:
maintainer-feedback+
|
Hardware: | Any | ||
OS: | Any | ||
Attachments: |
Description
James Elstone
2017-01-18 00:03:52 UTC
Created attachment 186806 [details]
Poudriere Log for py27-PyStaticConfiguration
Built successfully against head@450547 using 11.1-RELEASE-p1.
portlint -AC: looks fine. Ready for committer review please! Thank you for contributing a new port James. A couple of review items ... - lowercase svn directory name and PORTNAME - Use = (not:=) for *_DEPENDS - Sort *_DEPENDS entries (alphabetically) Also, if you could ask upstream to add their LICENSE file to the source distribution (sdist), likely via adding it to MANIFEST.in, that would be great (In reply to Kubilay Kocak from comment #3) Hi Kubilay, 1) Updated directory name and PORTNAME to be lowercase. 2) Revised assignment and sorted alphabetically the *_DEPENDS requirements 3) Created upstream issue to request LICENSE file is referenced correctly. Confirmed license in GitHub repository is indeed Apache 2.0. Cross-reference: https://github.com/dnephin/PyStaticConfiguration/issues/97 4) Bumped the port version to the latest 0.10.3 5) Re-ran portlint -AC ("looks fine") and have attached Poudriere logs of successful build. 6) Can this be committed please? Kind regards, James Created attachment 186959 [details]
Poudriere Log for py27-pystaticconfiguration
Created attachment 186960 [details]
Shell Archive file for py-pystaticconfiguration port, version 0.10.3
Contains comments made by committer.
Ready to be committed! There is a 0.10.4 now. Can you update? XBUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}six>=1.10.0:devel/py-six XRUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}yaml>=3.10:devel/py-yaml XTEST_DEPENDS= ${PYTHON_PKGNAMEPREFIX}pytest>=2.8.1:devel/py-pytest This needs to be updated for Python flavors. Please add @${PY_FLAVOR} to the end. |