Bug 216204

Summary: [NEW PORT] devel/py-pystaticconfiguration: Validating and reading configuration from heterogeneous formats
Product: Ports & Packages Reporter: James Elstone <james>
Component: Individual Port(s)Assignee: Tobias Kortkamp <tobik>
Status: Closed Feedback Timeout    
Severity: Affects Some People CC: james, koobs, miwi, python
Priority: --- Keywords: feature
Version: LatestFlags: james: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Shell archive of devel/py-PyStaticConfiguration
none
Poudriere Log for py27-PyStaticConfiguration
none
Poudriere Log for py27-pystaticconfiguration
none
Shell Archive file for py-pystaticconfiguration port, version 0.10.3 none

Description James Elstone 2017-01-18 00:03:52 UTC
Created attachment 179016 [details]
Shell archive of devel/py-PyStaticConfiguration

Addition of existing python package from "CHEESESHOP" for PyStaticConfiguration.

See here for python package index information:
https://pypi.python.org/pypi/PyStaticConfiguration/0.10.2

portlint -A : no warnings or errors
poudriere: builds OK.

Detail:
staticconf is a library for loading configuration values from many
heterogeneous formats and reading those values.

Configuration Loading:
Configuration is read from files or python objects (dict, list, or any object
with attributes), flattened, and merged into a container called a
staticconf.config.ConfigNamespace.

Reading configuration values:
Once configuration data is loaded into a staticconf.config.ConfigNamespace
there are three options for retrieving the configuration values.
Comment 1 James Elstone 2017-09-29 17:28:54 UTC
Created attachment 186806 [details]
Poudriere Log for py27-PyStaticConfiguration

Built successfully against head@450547 using 11.1-RELEASE-p1.
Comment 2 James Elstone 2017-09-29 17:30:46 UTC
portlint -AC:
looks fine.

Ready for committer review please!
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2017-10-04 01:47:01 UTC
Thank you for contributing a new port James.

A couple of review items ...

- lowercase svn directory name and PORTNAME
- Use = (not:=) for *_DEPENDS
- Sort *_DEPENDS entries (alphabetically)

Also, if you could ask upstream to add their LICENSE file to the source distribution (sdist), likely via adding it to MANIFEST.in, that would be great
Comment 4 James Elstone 2017-10-06 16:01:02 UTC
(In reply to Kubilay Kocak from comment #3)
Hi Kubilay,


1) Updated directory name and PORTNAME to be lowercase.

2) Revised assignment and sorted alphabetically the *_DEPENDS requirements

3) Created upstream issue to request LICENSE file is referenced correctly.
Confirmed license in GitHub repository is indeed Apache 2.0.
Cross-reference:
https://github.com/dnephin/PyStaticConfiguration/issues/97

4) Bumped the port version to the latest 0.10.3

5) Re-ran portlint -AC ("looks fine") and have attached Poudriere logs of successful build.

6) Can this be committed please?

Kind regards,

James
Comment 5 James Elstone 2017-10-06 16:01:37 UTC
Created attachment 186959 [details]
Poudriere Log for py27-pystaticconfiguration
Comment 6 James Elstone 2017-10-06 16:04:28 UTC
Created attachment 186960 [details]
Shell Archive file for py-pystaticconfiguration port, version 0.10.3

Contains comments made by committer.
Comment 7 James Elstone 2018-04-15 21:53:45 UTC
Ready to be committed!
Comment 8 Tobias Kortkamp freebsd_committer freebsd_triage 2019-02-27 07:26:14 UTC
There is a 0.10.4 now.  Can you update?

XBUILD_DEPENDS=	${PYTHON_PKGNAMEPREFIX}six>=1.10.0:devel/py-six
XRUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}yaml>=3.10:devel/py-yaml
XTEST_DEPENDS=	${PYTHON_PKGNAMEPREFIX}pytest>=2.8.1:devel/py-pytest

This needs to be updated for Python flavors.  Please add @${PY_FLAVOR}
to the end.