Bug 216215
I'd change the status to in progress, but I don't appear to have the necessary rights. I'll look into it shortly. Created attachment 179281 [details]
Proposed patch
Upstream: https://github.com/gpsbabel/gpsbabel/issues/62 Build success (12 amd64) here: https://secure.ohos.nl/downloads/gpsbabel-1.5.3.log Further poudriere builds successful for 10 i386, 10 amd64, 11 i386 and 11 amd64 Comment on attachment 179281 [details] Proposed patch nullptr is only available with -std=c++11 or later which this port doesn't pass. libc++ is unaffected due to using surrogate nullptr in C++98 mode unlike libstdc++. GCC defaults to C++98 before 6.0, so the fix would break FreeBSD on powerpc*/mips*/sparc64, DragonFly and users who forced lang/gcc or lang/gcc5. bushnell.cc: In function 'unsigned int bushnell_get_icon_from_name(QString)': bushnell.cc:138:39: error: 'nullptr' was not declared in this scope for (t = bushnell_icons; t->icon != nullptr; t++) { ^ bushnell.cc: In function 'const char* bushnell_get_name_from_symbol(int)': bushnell.cc:150:39: error: 'nullptr' was not declared in this scope for (t = bushnell_icons; t->icon != nullptr; t++) { ^ Note, NULL is promoted to nullptr with -std=c++11 on FreeBSD since 9.1 (see base r228918). A commit references this bug: Author: jbeich Date: Tue Jan 24 16:38:23 UTC 2017 New revision: 432358 URL: https://svnweb.freebsd.org/changeset/ports/432358 Log: astro/gpsbabel: unbreak with clang 4.0 bushnell.cc:138:36: error: ordered comparison between pointer and zero ('const char *' and 'int') for (t = bushnell_icons; t->icon > 0; t++) { ~~~~~~~ ^ ~ bushnell.cc:150:36: error: ordered comparison between pointer and zero ('const char *' and 'int') for (t = bushnell_icons; t->icon > 0; t++) { ~~~~~~~ ^ ~ PR: 216215 Submitted by: Oliver Heesakkers <dev2@heesakkers.info> (maintainer) Changes: head/astro/gpsbabel/files/patch-bushnell.cc Thanks. Landed. A commit references this bug: Author: jbeich Date: Tue Jan 24 16:42:43 UTC 2017 New revision: 432359 URL: https://svnweb.freebsd.org/changeset/ports/432359 Log: MFH: r432358 astro/gpsbabel: unbreak with clang 4.0 bushnell.cc:138:36: error: ordered comparison between pointer and zero ('const char *' and 'int') for (t = bushnell_icons; t->icon > 0; t++) { ~~~~~~~ ^ ~ bushnell.cc:150:36: error: ordered comparison between pointer and zero ('const char *' and 'int') for (t = bushnell_icons; t->icon > 0; t++) { ~~~~~~~ ^ ~ PR: 216215 Submitted by: Oliver Heesakkers <dev2@heesakkers.info> (maintainer) Approved by: ports-secteam blanket Changes: _U branches/2017Q1/ branches/2017Q1/astro/gpsbabel/files/patch-bushnell.cc |
bushnell.cc:138:36: error: ordered comparison between pointer and zero ('const char *' and 'int') for (t = bushnell_icons; t->icon > 0; t++) { ~~~~~~~ ^ ~ bushnell.cc:150:36: error: ordered comparison between pointer and zero ('const char *' and 'int') for (t = bushnell_icons; t->icon > 0; t++) { ~~~~~~~ ^ ~ build log: http://sprunge.us/MYYK regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3