Bug 216217

Summary: multimedia/vdr-plugin-epgsearch: fails to build with clang 4.0
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: Jan Beich <jbeich>
Status: Closed FIXED    
Severity: Affects Only Me Keywords: needs-patch
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216016
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215861
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216015
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216046
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216051
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216052
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216056
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216058
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216019
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216072
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216074
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216075
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216076
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216159
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216176
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216194
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216197
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216198
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216199
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216200
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216203
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216206
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216211
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216213
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216214
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216215
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216216
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216218
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216221
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216222
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216227
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216228
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216233
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216234
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216235
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216253
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216354
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216355
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216356
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216357
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216358
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216615
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216617
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216618
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216619
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216620
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216621
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216622
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216623
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216624
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216626
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216627
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216629
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216630
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216631
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216632
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216633
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216634
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216635
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216636
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216637
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216638
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216639
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216640
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216641
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216642
Bug Depends on:    
Bug Blocks: 216008    

Description Jan Beich freebsd_committer 2017-01-18 08:38:12 UTC
epgsearchext.c:1506:50: error: ordered comparison between pointer and zero ('char *' and 'int')
         while (fgets(buffer, sizeof(buffer), f) > 0) {
                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
c++: warning: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated [-Wdeprecated]

build log: http://sprunge.us/cZBR
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
Comment 1 commit-hook freebsd_committer 2017-02-01 05:26:02 UTC
A commit references this bug:

Author: jbeich
Date: Wed Feb  1 05:25:02 UTC 2017
New revision: 432968
URL: https://svnweb.freebsd.org/changeset/ports/432968

Log:
  multimedia/vdr-plugin-epgsearch: unbreak with clang 4.0

  createcats.c:67:42: error: ordered comparison between pointer and zero ('char *' and 'int')
      if (fgets(buffer, sizeof(buffer), f) > 0) {
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  epgsearchext.c:1506:50: error: ordered comparison between pointer and zero ('char *' and 'int')
           while (fgets(buffer, sizeof(buffer), f) > 0) {
                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  c++: warning: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated [-Wdeprecated]

  PR:		216217
  Reported by:	antoine (via exp-run)

Changes:
  head/multimedia/vdr-plugin-epgsearch/files/patch-clang40
Comment 2 commit-hook freebsd_committer 2017-02-01 05:26:04 UTC
A commit references this bug:

Author: jbeich
Date: Wed Feb  1 05:25:16 UTC 2017
New revision: 432969
URL: https://svnweb.freebsd.org/changeset/ports/432969

Log:
  multimedia/vdr-plugin-vdrmanager: unbreak with clang 4.0

  sock.cpp:23:13: error: ordered comparison between pointer and zero ('int (*)(int, int, int)' and 'int')
          if (socket >= 0) {
              ~~~~~~ ^  ~

  PR:		216217
  Reported by:	antoine (via exp-run)
  Obtained from:	upstream

Changes:
  head/multimedia/vdr-plugin-vdrmanager/Makefile
  head/multimedia/vdr-plugin-vdrmanager/files/patch-sock.cpp
Comment 3 commit-hook freebsd_committer 2017-02-01 12:59:25 UTC
A commit references this bug:

Author: jbeich
Date: Wed Feb  1 12:58:41 UTC 2017
New revision: 433028
URL: https://svnweb.freebsd.org/changeset/ports/433028

Log:
  MFH: r432968

  multimedia/vdr-plugin-epgsearch: unbreak with clang 4.0

  createcats.c:67:42: error: ordered comparison between pointer and zero ('char *' and 'int')
      if (fgets(buffer, sizeof(buffer), f) > 0) {
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  epgsearchext.c:1506:50: error: ordered comparison between pointer and zero ('char *' and 'int')
           while (fgets(buffer, sizeof(buffer), f) > 0) {
                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  c++: warning: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated [-Wdeprecated]

  PR:		216217
  Reported by:	antoine (via exp-run)
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2017Q1/
  branches/2017Q1/multimedia/vdr-plugin-epgsearch/files/patch-clang40
Comment 4 commit-hook freebsd_committer 2017-02-01 13:00:28 UTC
A commit references this bug:

Author: jbeich
Date: Wed Feb  1 13:00:03 UTC 2017
New revision: 433029
URL: https://svnweb.freebsd.org/changeset/ports/433029

Log:
  MFH: r432969

  multimedia/vdr-plugin-vdrmanager: unbreak with clang 4.0

  sock.cpp:23:13: error: ordered comparison between pointer and zero ('int (*)(int, int, int)' and 'int')
          if (socket >= 0) {
              ~~~~~~ ^  ~

  PR:		216217
  Reported by:	antoine (via exp-run)
  Obtained from:	upstream
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2017Q1/
  branches/2017Q1/multimedia/vdr-plugin-vdrmanager/Makefile
  branches/2017Q1/multimedia/vdr-plugin-vdrmanager/files/patch-sock.cpp