Bug 216253
Adriaan is looking at this (and similiar failures elsewhere in pykde4). https://docs.python.org/2/c-api/list.html [Probably _SetItem wanted instead of _SET_ITEM] A commit references this bug: Author: tcberner Date: Fri Jan 20 12:20:15 UTC 2017 New revision: 431949 URL: https://svnweb.freebsd.org/changeset/ports/431949 Log: Fix py-pykde4 against newest clang PyList_SET_ITEM() is supposed to be void, but as a macro it's an expression and has a pointer value. Clang 4.0 trips on the bogus pointer comparison; given the comparison, it should be PyList_SetItem() which returns -1 on failure. As the produced code may be changed by this, bump PORTREVISION. PR: 216253 Submitted by: Adriaan de Groot <groot@kde.org> Reported by: jbeich Reviewed by: rakuco, tcberner Approved by: rakuco (mentor) Differential Revision: https://reviews.freebsd.org/D9253 Changes: head/devel/py-pykde4/Makefile head/devel/py-pykde4/files/patch-sip_phonon_abstractvideodataoutput.sip head/devel/py-pykde4/files/patch-sip_solid_powermanagement.sip head/devel/py-pykde4/files/patch-sip_solid_predicate.sip Tobias, can you request MFH to 2017Q1? This looks like a regular bugfix but has a slight risk if some consumers rely on the broken behavior. (In reply to Jan Beich (mail not working) from comment #3) will do A commit references this bug: Author: tcberner Date: Sat Jan 21 12:18:25 UTC 2017 New revision: 432026 URL: https://svnweb.freebsd.org/changeset/ports/432026 Log: MFH: r431949 Fix py-pykde4 against newest clang PyList_SET_ITEM() is supposed to be void, but as a macro it's an expression and has a pointer value. Clang 4.0 trips on the bogus pointer comparison; given the comparison, it should be PyList_SetItem() which returns -1 on failure. As the produced code may be changed by this, bump PORTREVISION. PR: 216253 Submitted by: Adriaan de Groot <groot@kde.org> Reported by: jbeich Reviewed by: rakuco, tcberner Approved by: rakuco (mentor) Differential Revision: https://reviews.freebsd.org/D9253 PR: 216253 Approved by: ports-secteam (junovitch), rakuco (mentor) Changes: _U branches/2017Q1/ branches/2017Q1/devel/py-pykde4/Makefile branches/2017Q1/devel/py-pykde4/files/patch-sip_phonon_abstractvideodataoutput.sip branches/2017Q1/devel/py-pykde4/files/patch-sip_solid_powermanagement.sip branches/2017Q1/devel/py-pykde4/files/patch-sip_solid_predicate.sip A commit references this bug: Author: tcberner Date: Sat Jan 21 12:18:25 UTC 2017 New revision: 432026 URL: https://svnweb.freebsd.org/changeset/ports/432026 Log: MFH: r431949 Fix py-pykde4 against newest clang PyList_SET_ITEM() is supposed to be void, but as a macro it's an expression and has a pointer value. Clang 4.0 trips on the bogus pointer comparison; given the comparison, it should be PyList_SetItem() which returns -1 on failure. As the produced code may be changed by this, bump PORTREVISION. PR: 216253 Submitted by: Adriaan de Groot <groot@kde.org> Reported by: jbeich Reviewed by: rakuco, tcberner Approved by: rakuco (mentor) Differential Revision: https://reviews.freebsd.org/D9253 PR: 216253 Approved by: ports-secteam (junovitch), rakuco (mentor) Changes: _U branches/2017Q1/ branches/2017Q1/devel/py-pykde4/Makefile branches/2017Q1/devel/py-pykde4/files/patch-sip_phonon_abstractvideodataoutput.sip branches/2017Q1/devel/py-pykde4/files/patch-sip_solid_powermanagement.sip branches/2017Q1/devel/py-pykde4/files/patch-sip_solid_predicate.sip |
sip/solid/predicate.sip:115:56: error: ordered comparison between pointer and zero ('PyObject *' (aka '_object *') and 'int') if (obj == NULL || PyList_SET_ITEM (l, i, obj) < 0) ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~ build log: http://sprunge.us/QUSZ regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3