Bug 216278
| Summary: | x11-drivers/xf86-input-wacom: minor clean-up | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Matthew Rezny <rezny> | ||||
| Component: | Individual Port(s) | Assignee: | Jan Beich <jbeich> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | Flags: | bugzilla:
maintainer-feedback?
(jbeich) |
||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Comment on attachment 179092 [details] clean up of x11-drivers/xf86-input-wacom > -USES= tar:bzip2 pathfix pkgconfig libtool > +USES= tar:bzip2 pathfix tar:bzip2 can be dropped as well. > +USE_XORG= x11 xext xinerama xrandr > -LDFLAGS+= -Wl,--as-needed # Xext Why? -Wl,--as-needed is used to garbage-collect unused libraries that make the package less flexible on upgrades e.g., due to SOVERSION bumps. This is shorter and less error-prone than doing the following: post-patch: @${REINPLACE_CMD} \ -e '/XPROTOS/s/ xext//' \ -e '/LIBS=/s/-lm//' \ [...] ${WRKSRC}/configure > -INSTALL_TARGET= install-strip Better move such cleanup into bug 216269. (In reply to Jan Beich (mail not working) from comment #1) You are right that tar:bzip2 is unneeded in USES because bsd.xorg.mk sets that for us. I had overlooked that detail. Regarding the LD_FLAGS, it was not clear what purpose those served. I could only guess from the terse comment that it was meant to compensate for xext missing from UES_XORG. If those linker flags still have a purpose after adding xext to the XORG_USES then of course that line should remain. |
Created attachment 179092 [details] clean up of x11-drivers/xf86-input-wacom Trim a few USES and USE_XORG items that are not needed. Removal of install-strip assumes PR216269. Checked with poudriere on 10 i386/amd64 and 11 i386/amd64/ppc64.