Bug 216379

Summary: sysutils/parallel: Update to 20170122
Product: Ports & Packages Reporter: Danilo G. Baio <dbaio>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Some People CC: howeyc
Priority: --- Flags: bugzilla: maintainer-feedback? (howeyc)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
parallel-20170122.patch
none
parallel-20170122-v02.patch none

Description Danilo G. Baio freebsd_committer freebsd_triage 2017-01-22 17:50:17 UTC
Created attachment 179222 [details]
parallel-20170122.patch

- Update to 20170122
- Create pkg-plist to simplify Makefile

Changelog: http://git.savannah.gnu.org/cgit/parallel.git/plain/NEWS

[Q/A]

portlint: OK (looks fine.)

testport:
   poudriere: i386|amd64 - 10.3 p16     (OK)
   poudriere: i386|amd64 - 11   p7      (OK)
   poudriere: i386|amd64 - 12   r312317 (OK)
Comment 1 howeyc 2017-01-22 18:42:09 UTC
Looks good to me.
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-01-22 18:58:32 UTC
I would suggest using PORTDOCS=* instead of a long pkg-plist.

BTW, sysutils/moreutils-parallel was removed in Sep 20, 2014. I think it's OK to remove CONFLICTS.
Comment 3 Danilo G. Baio freebsd_committer freebsd_triage 2017-01-22 19:39:59 UTC
Created attachment 179225 [details]
parallel-20170122-v02.patch

Thank you both, for the quick response.
Patch updated as suggested on comment 2.
Another round of poudriere buildtests were fine.
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-01-22 19:42:31 UTC
And here's the stage-qa result:

====> Running Q/A tests (stage-qa)
Error: '/usr/bin/perl' is an invalid shebang you need USES=shebangfix for 'bin/parcat'
Error: '/bin/bash' is an invalid shebang you need USES=shebangfix for 'bin/env_parallel'
*** Error code 1

Stop.
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-01-22 19:46:42 UTC
(In reply to Danilo G. Baio (dbaio) from comment #3)

It's OK now. Comment #4 is about the previous patch.
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-01-23 18:53:34 UTC
A commit references this bug:

Author: sunpoet
Date: Mon Jan 23 18:51:57 UTC 2017
New revision: 432281
URL: https://svnweb.freebsd.org/changeset/ports/432281

Log:
  Update to 20170122

  - Remove CONFLICTS: moreutils-parallel was removed in Sep 20, 2014
  - Use PLIST instead of PLIST_FILES
  - While I'm here:
    - Add missing DOCS_BUILD_DEPENDS
    - Remove redundant LOCALBASE/bin in DOCS_BUILD_DEPENDS

  Changes:	http://git.savannah.gnu.org/cgit/parallel.git/plain/NEWS
  PR:		216379
  Submitted by:	Danilo G. Baio (dbaio) <dbaio@bsd.com.br>
  Approved by:	Chris Howey <howeyc@gmail.com> (maintainer)

Changes:
  head/sysutils/parallel/Makefile
  head/sysutils/parallel/distinfo
  head/sysutils/parallel/pkg-plist
Comment 7 Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-01-23 19:00:11 UTC
Committed. Thanks!