Bug 216531

Summary: devel/p5-Event-Lib: fails to build with libevent >= 2.1
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: Jan Beich <jbeich>
Status: Closed FIXED    
Severity: Affects Only Me CC: fk
Priority: --- Keywords: needs-patch
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 216527    
Attachments:
Description Flags
Unbreak devel/p5-Event-Lib: unbreak after libevent 2.1 import fk: maintainer-approval+

Description Jan Beich freebsd_committer 2017-01-27 20:03:40 UTC
Bug 215598 is unlikely to wait on just one leaf port ending up BROKEN. If you want to make sure the port still builds, please, inform upstream.

Lib.xs:131:14: error: no member named 'ev_arg' in 'struct event'
    args->ev.ev_arg = (void*)sv;
    ~~~~~~~~ ^
Lib.xs:211:33: error: no member named 'ev_arg' in 'struct event'
        SvREFCNT_dec((SV*)args->ev.ev_arg);
                          ~~~~~~~~ ^
/usr/local/lib/perl5/5.24/mach/CORE/sv.h:347:58: note: expanded from macro 'SvREFCNT_dec'
#define SvREFCNT_dec(sv)        S_SvREFCNT_dec(aTHX_ MUTABLE_SV(sv))
                                                                ^
/usr/local/lib/perl5/5.24/mach/CORE/handy.h:74:42: note: expanded from macro 'MUTABLE_SV'
#define MUTABLE_SV(p)   ((SV *)MUTABLE_PTR(p))
                                           ^
/usr/local/lib/perl5/5.24/mach/CORE/handy.h:64:41: note: expanded from macro 'MUTABLE_PTR'
#  define MUTABLE_PTR(p) ({ void *_p = (p); _p; })
                                        ^
Lib.xs:585:29: error: no member named 'ev_arg' in 'struct event'
        SvREFCNT_inc((SV*)args->ev.ev_arg);
                          ~~~~~~~~ ^
/usr/local/lib/perl5/5.24/mach/CORE/sv.h:336:53: note: expanded from macro 'SvREFCNT_inc'
#define SvREFCNT_inc(sv)                S_SvREFCNT_inc(MUTABLE_SV(sv))
                                                                  ^
/usr/local/lib/perl5/5.24/mach/CORE/handy.h:74:42: note: expanded from macro 'MUTABLE_SV'
#define MUTABLE_SV(p)   ((SV *)MUTABLE_PTR(p))
                                           ^
/usr/local/lib/perl5/5.24/mach/CORE/handy.h:64:41: note: expanded from macro 'MUTABLE_PTR'
#  define MUTABLE_PTR(p) ({ void *_p = (p); _p; })
                                        ^
Lib.xs:692:33: error: no member named 'ev_arg' in 'struct event'
            SvREFCNT_dec((SV*)args->ev.ev_arg);
                              ~~~~~~~~ ^
/usr/local/lib/perl5/5.24/mach/CORE/sv.h:347:58: note: expanded from macro 'SvREFCNT_dec'
#define SvREFCNT_dec(sv)        S_SvREFCNT_dec(aTHX_ MUTABLE_SV(sv))
                                                                ^
/usr/local/lib/perl5/5.24/mach/CORE/handy.h:74:42: note: expanded from macro 'MUTABLE_SV'
#define MUTABLE_SV(p)   ((SV *)MUTABLE_PTR(p))
                                           ^
/usr/local/lib/perl5/5.24/mach/CORE/handy.h:64:41: note: expanded from macro 'MUTABLE_PTR'
#  define MUTABLE_PTR(p) ({ void *_p = (p); _p; })
                                        ^
4 errors generated.

build log: http://sprunge.us/iQZG
Comment 1 Fabian Keil 2017-01-28 09:54:09 UTC
The port was added as a dependency for security/trans-proxy-tor
which has been removed years ago due to being obsolete.

I'm not aware of any users of this port and think it should
simply be removed.

If there's enough time it could be deprecated first,
but it seems unlikely that anyone is going to miss it.
Comment 2 Fabian Keil 2017-02-10 14:58:03 UTC
Created attachment 179830 [details]
Unbreak devel/p5-Event-Lib: unbreak after libevent 2.1 import

Apparently the port would be missed after all, I've received a private request to fix it.

The attached patch unbreaks the port as far as poudriere testport is concerned.

As I no longer use the port I'm no longer in a position to properly test it and am therefore also dropping maintainership.
Comment 3 commit-hook freebsd_committer 2017-02-10 15:43:04 UTC
A commit references this bug:

Author: jbeich
Date: Fri Feb 10 15:42:09 UTC 2017
New revision: 433807
URL: https://svnweb.freebsd.org/changeset/ports/433807

Log:
  devel/p5-Event-Lib: unbreak after r433286

  - Add a patch to compile with libevent 2.1 (only compile-tested!) after
    https://github.com/libevent/libevent/commit/cba59e53253b
  - Reformat an existing patch through "make makepatch"
  - Drop maintainership as the current maintainer no longer uses the
    port and wishes to resign

  PR:		216531
  Submitted by:	Fabian Keil <fk@fabiankeil.de> (maintainer)

Changes:
  head/devel/p5-Event-Lib/Makefile
  head/devel/p5-Event-Lib/files/patch-Lib.xs
  head/devel/p5-Event-Lib/files/patch-Makefile.PL
Comment 4 Jan Beich freebsd_committer 2017-02-10 15:44:10 UTC
Thanks. Landed.