Summary: | page fault in t4iov_attach during boot, on Dell CS23-SH motherboards | ||||||
---|---|---|---|---|---|---|---|
Product: | Base System | Reporter: | Alan Somers <asomers> | ||||
Component: | kern | Assignee: | John Baldwin <jhb> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Some People | CC: | daveb, jhb, np, vangyzen | ||||
Priority: | --- | ||||||
Version: | CURRENT | ||||||
Hardware: | amd64 | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Alan Somers
2017-01-27 23:58:25 UTC
Hmm, I think I see the panic in that we don't check for pci_find_dbsf() returning NULL. However, I don't see how you have a matching PCI device that gets past the probe routine. Do you have 'pciconf -l' output? Oh, never mind. Somehow I missed checking the vendor ID. Please try the attached fix. Created attachment 179432 [details]
iov_attach.patch
The proposed patch fixes the problem; the only addition I required was to include one of the files that #defines PCI_VENDOR_ID_CHELSIO A commit references this bug: Author: jhb Date: Tue Jan 31 18:54:14 UTC 2017 New revision: 313020 URL: https://svnweb.freebsd.org/changeset/base/313020 Log: Fix a couple of issues with t4iov probe and attach. - Check for Chelsio vendor ID in probe routines. - Fail attach instead of faulting if pci_find_dbsf() doesn't find a device. PR: 216539 Reported by: asomers Tested by: Dave Baukus <daveb@spectralogic.com> MFC after: 3 days Sponsored by: Chelsio Communications Changes: head/sys/dev/cxgbe/t4_iov.c A commit references this bug: Author: jhb Date: Fri Feb 3 21:37:28 UTC 2017 New revision: 313175 URL: https://svnweb.freebsd.org/changeset/base/313175 Log: MFC 313020: Fix a couple of issues with t4iov probe and attach. - Check for Chelsio vendor ID in probe routines. - Fail attach instead of faulting if pci_find_dbsf() doesn't find a device. PR: 216539 Sponsored by: Chelsio Communications Changes: _U stable/11/ stable/11/sys/dev/cxgbe/t4_iov.c |