Bug 216566

Summary: [PATCH] kernel build error on STABLE-11 with bktr
Product: Base System Reporter: Andre Albsmeier <mail>
Component: kernAssignee: Thomas Zander <riggs>
Status: Closed FIXED    
Severity: Affects Some People CC: riggs
Priority: --- Keywords: patch
Version: 11.0-STABLE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch to msp34xx.c none

Description Andre Albsmeier 2017-01-29 07:05:41 UTC
Created attachment 179389 [details]
Patch to msp34xx.c

Is it just me seeing this or does nobody else use bktr
compiled into the kernel anymore:
  
...
cc -target i386-unknown-freebsd11.0 --sysroot=/usr/obj/src/src-11/tmp -B/usr/obj/src/src-11/tmp/usr/bin -c -O -pipe -march=pentium3 -g -nostdinc  -I. -I/src/src-11/sys -I/src/src-11/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -march=core2 -fno-ident -MD  -MF.depend.msp34xx.o -MTmsp34xx.o -mno-mmx -mno-sse -msoft-float -ffreestanding -fwrapv -fstack-protector -gdwarf -2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__  -Wmissing-include-
dirs -fdiagnostics-show-option  -Wno-unknown-pragmas  -Wno-error-tautological-compare -Wno-error-empty-body  -Wno-error-parentheses-equality -Wno-error-unused-function  -Wno-error-pointer-sign -Wno-error-shift-negative-value  -mno-aes -mno-avx  -std=iso9899:1999 -Werror  /src/src-11/sys/dev/bktr/msp34xx.c
/src/src-11/sys/dev/bktr/msp34xx.c:112:18: error: unused variable 'bl_dfp' [-Werror,-Wunused-const-variable]
static const int bl_dfp[] = {
                 ^
 
Removing the bl_dfp definition fixes it, see patch
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-04-21 18:43:43 UTC
A commit references this bug:

Author: riggs
Date: Sat Apr 21 18:43:09 UTC 2018
New revision: 332861
URL: https://svnweb.freebsd.org/changeset/base/332861

Log:
  Remove unused definition bl_dfp; fix build with bktr compiled into kernel

  PR:		216566
  Submitted by:	mail@fbsd.e4m.org
  Reviewed by:	riggs, cognet
  Approved by:	cognet
  MFC after:	3 days

Changes:
  head/sys/dev/bktr/msp34xx.c
Comment 2 Thomas Zander freebsd_committer freebsd_triage 2018-04-24 10:08:28 UTC
MFC'ed to stable/10 and stable/11