Bug 216591
| Summary: | Mk/bsd.xorg.mk: support :build | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | John Hein <jcfyecrayz> | ||||||
| Component: | Ports Framework | Assignee: | freebsd-x11 (Nobody) <x11> | ||||||
| Status: | Closed Overcome By Events | ||||||||
| Severity: | Affects Only Me | CC: | portmgr, ports-bugs, zeising | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Bug Depends on: | 238988 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
over to maintainer Created attachment 179430 [details]
[patch] [v2] add :build support to bsd.xorg.mk
Fix patch - remove extra brace level.
Hi! I'm not sure :build is actually needed. Almost all things in Uses/xorg.mk are libraries, which would be both build- and runtime needed anyway. Thank you for the submission! I don't think we need a :build in the USES=xorg infrastructure. Almost everything there is shared libraries which are going to be needed at runtime, and no port today, as far as I know, needs any xorg component at runtime unless it's already in the xorg infra. |
Created attachment 179413 [details] [patch] add :build support to bsd.xorg.mk There's a few places in the tree including bsd.xorg.mk itself that expected USE_XORG to support a :build option for components. As far as I can see, the infrastructure never has supported it. Attached is a patch to not include :build components in RUN_DEPENDS. There are probably a number of cases in the tree that could/should use :build for xorg components, but that's a followup exercise enabled by this patch.