Bug 216617

Summary:	science/InsightToolkit: fails to build with clang 4.0
Product:	Ports & Packages	Reporter:	Jan Beich <jbeich>
Component:	Individual Port(s)	Assignee:	Ben Woods <woodsb02>
Status:	Closed FIXED
Severity:	Affects Only Me	Keywords:	needs-patch
Priority:	---	Flags:	woodsb02: maintainer-feedback+ woodsb02: merge-quarterly+
Version:	Latest
Hardware:	Any
OS:	Any
See Also:	https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216075 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216074 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216072 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216016 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215861 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216015 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216046 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216051 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216052 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216056 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216058 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216019 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216159 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216176 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216194 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216197 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216198 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216199 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216200 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216203 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216206 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216211 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216213 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216214 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216215 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216216 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216217 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216218 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216221 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216222 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216227 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216228 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216233 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216234 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216235 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216253 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216354 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216355 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216356 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216357 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216358 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216076 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216615 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216618 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216619 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216620 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216621 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216622 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216623 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216624 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216626 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216632 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216629 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216631 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216630 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216627 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216633 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216634 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216635 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216636 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216637 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216638 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216639 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216640 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216641 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216642
Bug Depends on:
Bug Blocks:	216008

Description Jan Beich freebsd_committer

2017-01-30 22:20:13 UTC

Modules/ThirdParty/VNL/src/vxl/v3p/netlib/linalg/lsqrBase.cxx:565:14: error: ordered comparison between pointer and zero ('std::ostream *' (aka 'basic_ostream<char> *') and 'int')
    if (nout > 0)
        ~~~~ ^ ~

build log: http://package18.nyi.freebsd.org/data/headamd64PR216008-default/2017-01-29_16h09m05s/logs/errors/InsightToolkit-4.10.1.log
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3

Comment 1 Ben Woods freebsd_committer

2017-02-05 13:25:22 UTC

Reported upstream: http://public.kitware.com/pipermail/community/2017-February/012629.html

Comment 2 Ben Woods freebsd_committer

2017-04-15 02:57:37 UTC

Fix has been committed upstream in ITK:
http://review.source.kitware.com/#/c/22043/

It has also been reported further upstream to VXL:
https://github.com/vxl/vxl/pull/374

Comment 3 commit-hook freebsd_committer

2017-04-15 03:02:35 UTC

A commit references this bug:

Author: woodsb02
Date: Sat Apr 15 03:01:24 UTC 2017
New revision: 438570
URL: https://svnweb.freebsd.org/changeset/ports/438570

Log:
  science/InsightToolkit: Fix build with clang 4.0

  PR:		216617
  Reported by:	jbeich
  Obtained from:	http://review.source.kitware.com/#/c/22043/
  MFH:		2017Q2

Changes:
  head/science/InsightToolkit/files/
  head/science/InsightToolkit/files/patch-Modules_ThirdParty_VNL_src_vxl_v3p_netlib_linalg_lsqrBase.cxx

Comment 4 commit-hook freebsd_committer

2017-04-15 03:04:38 UTC

A commit references this bug:

Author: woodsb02
Date: Sat Apr 15 03:04:21 UTC 2017
New revision: 438571
URL: https://svnweb.freebsd.org/changeset/ports/438571

Log:
  MFH: r438570

  science/InsightToolkit: Fix build with clang 4.0

  PR:		216617
  Reported by:	jbeich
  Obtained from:	http://review.source.kitware.com/#/c/22043/

  Approved by:	ports-secteam blanket

Changes:
_U  branches/2017Q2/
  branches/2017Q2/science/InsightToolkit/files/

Comment 5 Ben Woods freebsd_committer

2017-04-15 03:05:33 UTC

Committed. Thanks for reporting this.