Bug 216626

Summary:	games/ri-li: fails to build with clang 4.0
Product:	Ports & Packages	Reporter:	Jan Beich <jbeich>
Component:	Individual Port(s)	Assignee:	Dmitry Marakasov <amdmi3>
Status:	Closed FIXED
Severity:	Affects Only Me	Keywords:	needs-patch
Priority:	---	Flags:	bugzilla: maintainer-feedback? (amdmi3)
Version:	Latest
Hardware:	Any
OS:	Any
See Also:	https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216075 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216074 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216072 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216016 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215861 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216015 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216046 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216051 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216052 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216056 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216058 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216019 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216159 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216176 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216194 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216197 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216198 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216199 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216200 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216203 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216206 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216211 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216213 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216214 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216215 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216216 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216217 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216218 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216221 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216222 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216227 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216228 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216233 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216234 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216235 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216253 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216354 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216355 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216356 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216357 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216358 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216076 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216615 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216617 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216618 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216619 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216620 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216621 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216622 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216623 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216624 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216632 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216629 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216631 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216630 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216627 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216633 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216634 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216635 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216636 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216637 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216638 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216639 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216640 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216641 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216642
Bug Depends on:
Bug Blocks:	216008

Description Jan Beich freebsd_committer

2017-01-30 22:41:48 UTC

sprite.cc:354:16: error: ordered comparison between pointer and zero ('SDL_Surface *' and 'long')
    if(Image[i]<=NULL) {
       ~~~~~~~~^ ~~~~
sprite.cc:488:14: error: ordered comparison between pointer and zero ('SDL_Surface *' and 'long')
  if(Image[0]<=NULL) {
     ~~~~~~~~^ ~~~~

build log: http://package18.nyi.freebsd.org/data/headamd64PR216008-default/2017-01-29_16h09m05s/logs/errors/Ri-li-2.0.1_7.log
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3

Comment 1 Dmitry Marakasov freebsd_committer

2017-02-01 14:20:27 UTC

Should be fixed with r433036.

Comment 2 Jan Beich freebsd_committer

2017-02-01 14:51:11 UTC

There's one more:

tableau.cc:90:9: error: ordered comparison between pointer and zero ('unsigned char *' and 'int')
  if(Buf<=0) return false;
     ~~~^ ~

Comment 3 Jan Beich freebsd_committer

2017-02-02 20:30:59 UTC

http://package18.nyi.freebsd.org/data/headi386PR216008-default/2017-02-02_16h22m03s/logs/errors/Ri-li-2.0.1_7.log

Comment 4 commit-hook freebsd_committer

2017-02-10 17:13:22 UTC

A commit references this bug:

Author: amdmi3
Date: Fri Feb 10 17:12:23 UTC 2017
New revision: 433815
URL: https://svnweb.freebsd.org/changeset/ports/433815

Log:
  - Fix build with clang 4.0

  PR:		216626

Changes:
  head/games/ri-li/files/patch-src_tableau.cc