Bug 216691

Summary: editors/codelite 10.0 depends on package: clang39>0 - not found
Product: Ports & Packages Reporter: Ivan Rozhuk <rozhuk.im>
Component: Individual Port(s)Assignee: Mahdi Mokhtari <mmokhi>
Status: Closed FIXED    
Severity: Affects Some People CC: matthew, mmokhi, ohartmann, rozhuk.im
Priority: --- Flags: mmokhi: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://reviews.freebsd.org/D9412
Attachments:
Description Flags
Patch that fixes the clang$v options
mmokhi: maintainer-approval+
Updated the patch based on latest changes of review (correct using of `BUILD_DEPENDS`) mmokhi: maintainer-approval+

Description Ivan Rozhuk 2017-02-01 11:33:21 UTC 
===>  License GPLv2+ accepted by the user
===>  Found saved configuration for codelite-10.0
===>   codelite-10.0 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by codelite-10.0 for building
===>  Extracting for codelite-10.0
=> SHA256 Checksum OK for eranif-codelite-10.0_GH0.tar.gz.
===>  Patching for codelite-10.0
===>   Converting DOS text files to UNIX text files
===>  Applying FreeBSD patches for codelite-10.0
===>   codelite-10.0 depends on package: clang39>0 - not found
Error a dependency refers to a non existing origin: /usr/ports/lang/clang39 in BUILD_DEPENDS
===>   codelite-10.0 depends on file: /usr/local/bin/cmake - found
===>   codelite-10.0 depends on executable: msgfmt - found
===>   codelite-10.0 depends on executable: gtk-update-icon-cache - found
Errors with dependencies.
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/editors/codelite
*** Error code 1
Comment 1 Matthew Seaman freebsd_committer freebsd_triage 2017-02-01 12:49:27 UTC 
Seems there is no lang/clang39 port although there is a devel/llvm39
Comment 2 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-02-01 12:59:02 UTC 
(In reply to Matthew Seaman from comment #1)
Hi.
yeah, I didn't noticed that :)
I changed the Makefile for llvm39 instead of clang39, If the test goes fine I'll submit the patch.
Comment 3 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-02-01 23:08:01 UTC 
Created attachment 179502 [details]
Patch that fixes the clang$v options
Comment 4 O. Hartmann 2017-02-02 08:03:23 UTC 
(In reply to Mahdi Mokhtari from comment #3)

I just reeled in the most recent port updates via svn and it still fails to build with CLANG39
Comment 5 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-02-02 09:51:45 UTC 
(In reply to O. Hartmann from comment #4)
Did you test the attached patch?
It's not committed yet.
(I've tested the patch myself with CLANG36 and 39 and it works)
Comment 6 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-02-02 16:42:33 UTC 
Created attachment 179535 [details]
Updated the patch based on latest changes of review (correct using of `BUILD_DEPENDS`)
Comment 7 Ivan Rozhuk 2017-02-02 20:50:12 UTC 
Build and install OK.

But crash on auto completion if clang auto completion is on, same happen with previous codelite versions if clang > 3.6.
Comment 8 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-02-02 21:53:53 UTC 
(In reply to rozhuk.im from comment #7)
> Build and install OK.
Thanks for confirming :)


> But crash on auto completion if clang auto completion is on, same happen with previous codelite versions if clang > 3.6.
I've tested it on my system, it works fine here.
Would you please provide more info?
Though maybe we can continue the new issue (after providing new info) on new separate PR.

Thanks.
Comment 9 Ivan Rozhuk 2017-02-03 10:45:51 UTC 
I try investigate this, and make new PR if it is not specific for me.
Comment 10 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-02-03 17:24:52 UTC 
(In reply to rozhuk.im from comment #9)
OK, thanks! :-)
Comment 11 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-02-05 08:55:39 UTC 
Hey, This is still uncommitted in Port Tree. :-D
Please don't open issues while they're not committed in.
Comment 12 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-02-05 21:50:31 UTC 
(In reply to Mahdi Mokhtari from comment #11)

***err Sorry for such error in my writing :)
s/open issues/close issues/g
Comment 13 commit-hook freebsd_committer freebsd_triage 2017-02-11 07:27:07 UTC 
A commit references this bug:

Author: mmokhi
Date: Sat Feb 11 07:26:53 UTC 2017
New revision: 433838
URL: https://svnweb.freebsd.org/changeset/ports/433838

Log:
  Fix clang39 dependency on editors/codelite

  PR:		216691
  Submitted by:	mmokhi (maintainer)
  Reported by:	rozhuk.im@gmail.com
  Reviewed by:	feld, mat
  Approved by:	feld, mat (mentors)
  Differential Revision:	https://reviews.freebsd.org/D9412

Changes:
  head/editors/codelite/Makefile