Bug 216894
| Summary: | [PATCH] news/nzbget: Improve and simplify rc script | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Mark Felder <feld> | ||||
| Component: | Individual Port(s) | Assignee: | Mark Felder <feld> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | toxic | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | Flags: | amdmi3:
maintainer-feedback-
feld: merge-quarterly+ |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Maintainer timeout A commit references this bug: Author: feld Date: Wed Feb 22 22:24:16 UTC 2017 New revision: 434648 URL: https://svnweb.freebsd.org/changeset/ports/434648 Log: news/nzbget: rc script improvement nzbget obeys normal signals. Use them instead of needlessly complicating the rc script. PR: 216894 Approved by: maintainer timeout MFH: 2017Q1 Changes: head/news/nzbget/Makefile head/news/nzbget/files/nzbget.in A commit references this bug: Author: feld Date: Wed Feb 22 22:24:53 UTC 2017 New revision: 434649 URL: https://svnweb.freebsd.org/changeset/ports/434649 Log: MFH: r434648 news/nzbget: rc script improvement nzbget obeys normal signals. Use them instead of needlessly complicating the rc script. PR: 216894 Approved by: maintainer timeout Approved by: ports-secteam (with hat) Changes: _U branches/2017Q1/ branches/2017Q1/news/nzbget/Makefile branches/2017Q1/news/nzbget/files/nzbget.in |
Created attachment 179721 [details] rc script improvement nzbget properly handles SIGTERM. There's no reason to require it to use its own binary to self-signal shutdown. I have been running into issues with nzbget processes which get stuck in nanslp state and are no longer listening on the network socket, so "service nzbget stop" doesn't work because it can't communicate over its web api. If you pass it SIGTERM it shuts down cleanly. Additionally, this fixes the need to induce a sleep for the restart command. I can do service restarts without a problem; nzbget starts cleanly every time.