Bug 216943
| Summary: | [exp-run] conditionalize inclusion of firebird25 for various tier-2 archs | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Mark Linimon <linimon> | ||||||
| Component: | Ports Framework | Assignee: | Port Management Team <portmgr> | ||||||
| Status: | Closed Overcome By Events | ||||||||
| Severity: | Affects Some People | CC: | adridg, linimon, mmel, ports-bugs | ||||||
| Priority: | --- | Flags: | linimon:
exp-run?
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| URL: | https://reviews.freebsd.org/D14326 | ||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=214747 | ||||||||
| Attachments: |
|
||||||||
For databases/soci, you should leave the OPTIONS_DEFAULT alone and only set OPTIONS_EXCLUDE_arch, it would do the same thing. Also, I do not understand the statement about OPTIONS_INCLUDE, there is no such thing as OPTIONS_INCLUDE. A commit references this bug: Author: linimon Date: Sun May 14 06:52:09 UTC 2017 New revision: 440865 URL: https://svnweb.freebsd.org/changeset/ports/440865 Log: Disable dependency on firebird for tier-2 archs. There is work underway to fix firebird on those archs but it is not complete. This unbreaks several dozen ports on tier-2. PR: 216943 Submitted by: linimon Reviewed by: mat (only this file) Changes: head/databases/soci/Makefile Created attachment 182581 [details]
revised patch for qt4 fixes
Updated patch with databases/soci removed.
After testing the suggested revision to the databases/soci patch on both amd64 and powerpc64, I have committed it. I would still like to see an -exp run for the remaining parts of the patch. r441257 | jkim | 2017-05-19 20:42:01 +0200 (Fri, 19 May 2017) | 5 lines That commit dropped firebird from USES, so that part no longer applies. The qt4 bits I've put in a review for commit. A commit references this bug: Author: adridg Date: Fri Mar 2 13:07:57 UTC 2018 New revision: 463394 URL: https://svnweb.freebsd.org/changeset/ports/463394 Log: Disable Qt4 sql-ibase plugin on not-(i386|amd64) ibase is Firebird, which only builds on i386 and amd64. This patch squashes the ibase plugin for Qt4. PR: 216943 Submitted by: linimon Reported by: linimon Approved by: tcberner (mentor) Differential Revision: https://reviews.freebsd.org/D14326 Changes: head/Mk/bsd.qt.mk head/databases/qt4-ibase-plugin/Makefile head/devel/qt4/Makefile With the qt4 patch committed (thanks linimon@), and I've done the same for Qt5, this PR can probably be closed. |
Created attachment 179800 [details] patch for qt4 fixes databases/firebird25-server is a dependency of most qt4 ports. However, it does not build on several tier-2 archs. The following patch conditionalizes its dependency so that various qt4 ports are unblocked, especially on armv6. I have been able to build the following on armv6: accessibility/qt4-accessible databases/qt4-mysql-plugin devel/qt4-help devel/qt4-help-tools devel/qt4-makeqpf devel/qt4-qdbusviewer devel/qt4-qdoc3 devel/qt4-qt3support devel/qt4-qvfb devel/qt4-uic3 graphics/qt4-iconengines graphics/qt4-imageformats graphics/qt4-opengl graphics/qt4-pixeltool graphics/qt4-svg multimedia/qt4-multimedia x11-toolkits/qt4-gui x11/qt4-graphicssystems-opengl x11/qt4-inputmethods The patch seems harmless on amd64.