Bug 217095

Summary: www/node*: enable BUNDLED_SSL by default only on FreeBSD 10
Product: Ports & Packages Reporter: Bradley T. Hughes <bhughes>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Many People CC: tijl
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 217096    
Attachments:
Description Flags
www/node*: enable BUNDLED_SSL by default only on FreeBSD 10 bhughes: maintainer-approval+

Description Bradley T. Hughes freebsd_committer freebsd_triage 2017-02-14 12:59:59 UTC
Created attachment 179983 [details]
www/node*: enable BUNDLED_SSL by default only on FreeBSD 10

Do not enable BUNDLED_SSL by default where base openssl is new enough,
meaning FreeBSD 11 and up. Include a message in UPDATING about the
change. Bump PORTREVISION due to the change in defaults.

Ideally, we should strive to use a shared OpenSSL on all FreeBSD versions,
but we are not there yet (see r433456). Once the ports defaults change to
stop using base openssl, we can remove this restriction and enable a shared
openssl build for Node.js everywhere.
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-02-14 16:15:13 UTC
A commit references this bug:

Author: sunpoet
Date: Tue Feb 14 16:15:02 UTC 2017
New revision: 434123
URL: https://svnweb.freebsd.org/changeset/ports/434123

Log:
  Enable BUNDLED_SSL by default only on FreeBSD 10

  - Add UPDATING entry
  - Bump PORTREVISION for dependency change

  PR:		217095
  Submitted by:	Bradley T. Hughes <bradleythughes@fastmail.fm> (maintainer)

Changes:
  head/UPDATING
  head/www/node/Makefile
  head/www/node4/Makefile
  head/www/node6/Makefile
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-02-14 16:21:17 UTC
Committed. Thanks!
Comment 3 Bradley T. Hughes freebsd_committer freebsd_triage 2017-02-15 09:02:58 UTC
Thanks :)