Bug 217147

Summary: astro/gpsd: please remove unnecessary dependencies
Product: Ports & Packages Reporter: jau
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Some People CC: jau, jcfyecrayz
Priority: --- Flags: amdmi3: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch none

Description jau 2017-02-16 18:12:56 UTC
The Makefile incorrectly specifies docbook-xsl and libxslt as
build time dependencies. It seems gpsd builds just fine without them.
Since those two pull in quite a bunch of other dependencies building
gpsd on an RPI2 becomes very time consuming, if they are allowed to
stay as dependencies for no reason.

Just remove the lines...

BUILD_DEPENDS=  docbook-xsl>=0:textproc/docbook-xsl \
		xsltproc:textproc/libxslt
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2017-02-21 10:40:25 UTC
Created attachment 180181 [details]
Patch

Confirmed - built man pages are included into the distribution so there's not reason to rebuild them. I propose this patch which removes unneeded depends and also add manbuild=no to behave consistently and not rebuild manpages even when the depends are present.
Comment 2 John Hein 2017-02-23 02:12:08 UTC
I think this is probably okay.  I'd like to get bug 207273 committed first - it's been pending for a long time.  Any comitters listening?
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2017-05-02 18:13:08 UTC
The update was committed, this PR is still actual. Builds fine with these changes.
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-05-31 17:48:07 UTC
A commit references this bug:

Author: amdmi3
Date: Wed May 31 17:46:59 UTC 2017
New revision: 442248
URL: https://svnweb.freebsd.org/changeset/ports/442248

Log:
  - Don't needlessly rebuild bundled manpages, drop unneeded build depends

  PR:		217147
  Submitted by:	jau@iki.fi
  Approved by:	z7dr6ut7gs@snkmail.com (maintainer)

Changes:
  head/astro/gpsd/Makefile