Bug 217264
| Summary: | devel/py-dateutil: dos2unix is incorrectly run on tar.gz file | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Gordon Tetlow <gordon> |
| Component: | Individual Port(s) | Assignee: | Kubilay Kocak <koobs> |
| Status: | Closed FIXED | ||
| Severity: | Affects Many People | Flags: | koobs:
maintainer-feedback+
koobs: merge-quarterly- |
| Priority: | --- | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
Ping. Can this get submitted please? Or let me know and I'll submit an update. Apologies for the delay Gordon. For future issues, please include changes as attachments (not comments), or ideally Phabricator reviews with the URL in the Bugzilla URl field. The latter allows us to more quickly review/accept changes and allow you to commit the changes (with a complete audit/review trail) A commit references this bug: Author: koobs Date: Sun Apr 30 04:52:00 UTC 2017 New revision: 439790 URL: https://svnweb.freebsd.org/changeset/ports/439790 Log: devel/py-dateutil: Remove use of dos2unix The file installed as dateutil-zoneinfo.tar.gz is corrupted by the dos2unix run on all of the files in the distribution. There is no need to run dos2unix as the only files with CRLF is the NEWS file, a README and a Windows BAT file (which makes sense to use CRLF). Accordingly: - Remove use of USES=dos2unix - Bump PORTREVISION to rebuild package (containing corrupted TZ data file) PR: 217264 Submitted by: gordon MFH: 2017Q2 Changes: head/devel/py-dateutil/Makefile Re-open pending MFH (merge to quarterly) :) New quarterly has been cut, deny MFH. |
The file installed as dateutil-zoneinfo.tar.gz is corrupted by the dos2unix run on all of the files in the distribution. Looking at it a bit further, there is no need to run dos2unix as the only files with CRLF is the NEWS file, a README and a Windows BAT file (which makes sense to use CRLF). Proposed diff: Index: Makefile =================================================================== --- Makefile (revision 434502) +++ Makefile (working copy) @@ -3,6 +3,7 @@ PORTNAME= dateutil PORTVERSION= 2.5.3 +PORTREVISION= 1 CATEGORIES= devel python PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} @@ -14,7 +15,7 @@ RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}six>=1.5:devel/py-six -USES= python dos2unix +USES= python USE_GITHUB= yes USE_PYTHON= autoplist distutils