Summary: | Deadlock in if_clone.c | ||||||
---|---|---|---|---|---|---|---|
Product: | Base System | Reporter: | Daan Vreeken <FreeBSD-prs> | ||||
Component: | kern | Assignee: | Andriy Voskoboinyk <avos> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Many People | CC: | FreeBSD-prs, avos, emaste, glebius | ||||
Priority: | --- | Keywords: | patch | ||||
Version: | 10.3-STABLE | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Daan Vreeken
2017-02-27 16:51:27 UTC
Thanks for report, Daan. There is no attachment to the PR. I could reconstruct it from your description, but better you add it, so that we are on the same page. Created attachment 180348 [details] Fix for deadlock in if_clone.c Here's the missing attachment. The patch can also be downloaded from: http://www.vitsch.nl/pub_diffs/ Thanks! A commit references this bug: Author: avos Date: Mon Oct 16 21:21:31 UTC 2017 New revision: 324672 URL: https://svnweb.freebsd.org/changeset/base/324672 Log: ifnet(9): split ifc_alloc_unit() (should simplify code flow) Allocate smallest unit number from pool via ifc_alloc_unit_next() and exact unit number (if available) via ifc_alloc_unit_specific(). While here, address possible deadlock (mentioned in PR). PR: 217401 MFC after: 5 days Differential Revision: https://reviews.freebsd.org/D12551 Changes: head/sys/net/if_clone.c A commit references this bug: Author: avos Date: Sat Oct 21 10:21:34 UTC 2017 New revision: 324812 URL: https://svnweb.freebsd.org/changeset/base/324812 Log: MFC r324672: ifnet(9): split ifc_alloc_unit() (should simplify code flow) Allocate smallest unit number from pool via ifc_alloc_unit_next() and exact unit number (if available) via ifc_alloc_unit_specific(). While here, address possible deadlock (mentioned in PR). PR: 217401 Differential Revision: https://reviews.freebsd.org/D12551 Changes: _U stable/11/ stable/11/sys/net/if_clone.c A commit references this bug: Author: avos Date: Sat Oct 21 10:48:06 UTC 2017 New revision: 324813 URL: https://svnweb.freebsd.org/changeset/base/324813 Log: MFC r324672: ifnet(9): split ifc_alloc_unit() (should simplify code flow) Allocate smallest unit number from pool via ifc_alloc_unit_next() and exact unit number (if available) via ifc_alloc_unit_specific(). While here, address possible deadlock (mentioned in PR). PR: 217401 Differential Revision: https://reviews.freebsd.org/D12551 Changes: _U stable/10/ stable/10/sys/net/if_clone.c Should be fixed now. |