Bug 217452
| Summary: | net/dhcp6 command_flags does not need to be referenced inside of the command_args | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Andrey Pevnev <apevnev> | ||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Many People | CC: | leres, pi | ||||
| Priority: | --- | Flags: | pi:
maintainer-feedback-
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Created attachment 194713 [details]
patch
I noticed this today while working on a different dhcp6 problem. If you add:
dhcp6c_flags="-d"
to /etc/rc.conf you'll see that -d is applied twice:
ice 17 # ps wwu60049
USER PID %CPU %MEM VSZ RSS TT STAT STARTED TIME COMMAND
root 60049 0.0 0.0 8488 2492 - Ss 13:53 0:00.00 /usr/local/sbin/dhcp6c -d -c /usr/local/etc/dhcp6c.conf -p /var/run/dhcp6c.pid -d igb1
Here's the patch as an attachment; I'm happy to commit with maintainer approval.
Committed, thanks! A commit references this bug: Author: pi Date: Sun Sep 2 21:02:12 UTC 2018 New revision: 478819 URL: https://svnweb.freebsd.org/changeset/ports/478819 Log: net/dhcp6: several fixes - rcorder incorrect (Circular dependency on provision `DAEMON') - command_flags do not need to be referenced inside of the command_args - dhcp6s exits because of shutdown on non-connected UDP socket PR: 216673, 217452, 228994 Submitted by: tdb, Andrey Pevnev <apevnev@me.com>, leres, Dries Michiels <driesm.michiels@gmail.com> Approved by: hrs (maintainer timeout) Differential Revision: D16994 Changes: head/net/dhcp6/Makefile head/net/dhcp6/files/dhcp6c.in head/net/dhcp6/files/dhcp6s.in head/net/dhcp6/files/patch-dhcp6s.c |
Default port startup script results in the following command line (dhcp6c_flags is set to "-n" in /etc/rc.local): /usr/local/sbin/dhcp6c -n -c /usr/local/etc/dhcp6c.conf -p /var/run/dhcp6c.pid -n bge1 I suggest the following patch which removes duplicate -n argument just before the interface name: Index: dhcp6c.in =================================================================== --- dhcp6c.in (revision 435147) +++ dhcp6c.in (working copy) @@ -39,7 +39,7 @@ required_files="${dhcp6c_config}" pidfile="${dhcp6c_pidfile}" -command_args="-c ${dhcp6c_config} -p ${dhcp6c_pidfile} ${dhcp6c_flags} ${dhcp6c_interfaces}" +command_args="-c ${dhcp6c_config} -p ${dhcp6c_pidfile} ${dhcp6c_interfaces}" dhcp6c_precmd() {