Bug 217460
| Summary: | math/speedcrunch: update port to 0.12 | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | John Smith <godevilove> |
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | lightside, mikael, uzsolt |
| Priority: | --- | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
| Attachments: | |||
|
Description
John Smith
2017-03-01 20:26:48 UTC
Created attachment 180473 [details]
patch
Try the attached patch.
portlint ok
poudriere ok on amd64 12-current
Created attachment 180475 [details] Proposed patch (since 425617 revision) with mikael.urankar changes Hello. I attached slightly modified version of the patch by mikael.urankar in comment #1. - Changed MASTER_SITES [1] - Added BB_ACCOUNT, BB_PROJECT, BB_COMMIT variables [1] - Added sed patch for -Wno-shift-negative-value removal, because it unused during compilation by Clang - Recreated distinfo file [1] - based on proposed changes in bug 195576 comment #3. (In reply to mikael.urankar from comment #1) Thanks. Freebsd 11.0-RELEASE-p8 amd64 - the patch worked just fine (make plist-check). However, '/usr/ports/distfiles/branch-0.12.tar.gz' is not a very unique file name ( in distfiles (In reply to lightside from comment #2) Thanks, that worked fine too. I got 35 warnings with your patch : /usr/ports/math/speedcrunch/work/heldercorreia-speedcrunch-7f2565d6a0ad/src/math/floatnum.c:351:43: warning: shifting a negative signed value is undefined [-Wshift-negative-value] ... Wno-shift-negative-value was put to silence them: Helder Correia b01ace1 Fix Clang warning about left shift of negatives in floatnum https://bitbucket.org/heldercorreia/speedcrunch/diff/src/CMakeLists.txt?diff2=b01ace1b2f4d&at=presite Created attachment 180488 [details] Proposed patch (since 425617 revision) with mikael.urankar changes (In reply to comment #4) > I got 35 warnings with your patch Probably, latest version of Clang on FreeBSD 12 supports "-Wno-shift-negative-value" compiler's option. This is what it was on FreeBSD 10.3-RELEASE-p16, where Clang 3.4.1 used in base: warning: unknown warning option '-Wno-shift-negative-value'; did you mean '-Wno-shift-sign-overflow'? [-Wunknown-warning-option] (In reply to comment #4) > Wno-shift-negative-value was put to silence them Ok, I removed this sed patch. anyone? Created attachment 187022 [details]
Proposed patch (since 425617 revision) with mikael.urankar changes
I updated patch for latest FreeBSD ports with following additional changes:
- Add sed patch to remove custom options for compiler warnings
This removes messages about "unknown warning option '-Wno-shift-negative-value'" from Clang's compiler output on FreeBSD 10.
I think, possible to ignore portlint's warning about PLIST_FILES, if pkg-plist file already available.
Created attachment 187023 [details]
Proposed patch (since 425617 revision) with mikael.urankar changes
Sorted pkg-plist.
Closing this PR was invalid. Take. A commit references this bug: Author: amdmi3 Date: Mon Oct 9 14:57:12 UTC 2017 New revision: 451619 URL: https://svnweb.freebsd.org/changeset/ports/451619 Log: - Update to 0.12.0 - Chase move to bitbucket - Pass maintainership to submitter PR: 217460 Submitted by: mikael.urankar@gmail.com, lightside@gmx.com Reported by: godevilove@ya.ru Changes: head/math/speedcrunch/Makefile head/math/speedcrunch/distinfo head/math/speedcrunch/files/ head/math/speedcrunch/pkg-plist |
