Bug 217528
| Summary: | lib/msun/ctrig_test fails with clang 4.0+ | ||
|---|---|---|---|
| Product: | Base System | Reporter: | Enji Cooper <ngie> |
| Component: | tests | Assignee: | Dimitry Andric <dim> |
| Status: | Closed FIXED | ||
| Severity: | Affects Some People | CC: | dim, lwhsu, ngie |
| Priority: | --- | ||
| Version: | CURRENT | ||
| Hardware: | Any | ||
| OS: | Any | ||
|
Description
Enji Cooper
2017-03-04 08:56:00 UTC
A commit references this bug: Author: ngie Date: Sat Mar 4 09:16:52 UTC 2017 New revision: 314649 URL: https://svnweb.freebsd.org/changeset/base/314649 Log: Convert lib/msun/ctrig_test from TAP to ATF This is being done as a precursor for work needed to annontate failing testcases with clang 4.0+. MFC after: 1 week PR: 217528 Sponsored by: Dell EMC Isilon Changes: head/lib/msun/tests/Makefile head/lib/msun/tests/ctrig_test.c :test_zero_input is the testcase that's failing: https://ci.freebsd.org/job/FreeBSD-head-amd64-test/1946/testReport/junit/lib.msun/ctrig_test/test_zero_input/ . A commit references this bug: Author: ngie Date: Thu Mar 9 06:58:47 UTC 2017 New revision: 314951 URL: https://svnweb.freebsd.org/changeset/base/314951 Log: Expect :test_zero_input to fail on amd64 The clang 4.x+ upgrade now causes this testcase to fail, but only on amd64. More investigation will be done to determine the cause. MFC after: 1 week Reported by: Jenkins PR: 217528 Sponsored by: Dell EMC Isilon Changes: head/lib/msun/tests/ctrig_test.c A commit references this bug: Author: ngie Date: Sun Mar 12 04:40:02 UTC 2017 New revision: 315118 URL: https://svnweb.freebsd.org/changeset/base/315118 Log: MFC r305283,r314649: r305283: Skip :test_large on i386 More assertions are failing on ^/head now. PR: 205446 r314649: Convert lib/msun/ctrig_test from TAP to ATF This is being done as a precursor for work needed to annontate failing testcases with clang 4.0+. PR: 217528 Changes: _U stable/11/ stable/11/lib/msun/tests/Makefile stable/11/lib/msun/tests/ctrig_test.c A commit references this bug: Author: ngie Date: Thu Mar 16 02:09:51 UTC 2017 New revision: 315359 URL: https://svnweb.freebsd.org/changeset/base/315359 Log: MFC r314951: Expect :test_zero_input to fail on amd64 The clang 4.x+ upgrade now causes this testcase to fail, but only on amd64. More investigation will be done to determine the cause. PR: 217528 Changes: _U stable/11/ stable/11/lib/msun/tests/ctrig_test.c This should be dim's bug. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=a7b42c4b7f7ad7bd1b22ab57ed9185bdcea6f0a2 commit a7b42c4b7f7ad7bd1b22ab57ed9185bdcea6f0a2 Author: Alex Richardson <arichardson@FreeBSD.org> AuthorDate: 2021-02-15 22:06:41 +0000 Commit: Alex Richardson <arichardson@FreeBSD.org> CommitDate: 2021-02-15 22:55:12 +0000 msun: ctanh/ctanhf: Import fix from musl libc This applies musl commit b02eed9c4841913d690a2d0029737d72615384fe by Szabolcs Nagy and updates the tests accordingly. This also allows removing an XFAIL from the test. musl commit message: complex: fix ctanh(+-0+i*nan) and ctanh(+-0+-i*inf) These cases were incorrect in C11 as described by http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1886.htm PR: 217528 Reviewed By: dim MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D28578 lib/msun/src/s_ctanh.c | 8 +++++--- lib/msun/src/s_ctanhf.c | 2 +- lib/msun/tests/ctrig_test.c | 23 ++++++++--------------- 3 files changed, 14 insertions(+), 19 deletions(-) A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=8d42552e7b29eed31ec6b28d091d8c9b99d824fc commit 8d42552e7b29eed31ec6b28d091d8c9b99d824fc Author: Alex Richardson <arichardson@FreeBSD.org> AuthorDate: 2021-02-15 22:06:41 +0000 Commit: Alex Richardson <arichardson@FreeBSD.org> CommitDate: 2021-03-17 09:44:16 +0000 msun: ctanh/ctanhf: Import fix from musl libc This applies musl commit b02eed9c4841913d690a2d0029737d72615384fe by Szabolcs Nagy and updates the tests accordingly. This also allows removing an XFAIL from the test. musl commit message: complex: fix ctanh(+-0+i*nan) and ctanh(+-0+-i*inf) These cases were incorrect in C11 as described by http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1886.htm PR: 217528 Reviewed By: dim MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D28578 (cherry picked from commit a7b42c4b7f7ad7bd1b22ab57ed9185bdcea6f0a2) lib/msun/src/s_ctanh.c | 8 +++++--- lib/msun/src/s_ctanhf.c | 2 +- lib/msun/tests/ctrig_test.c | 23 ++++++++--------------- 3 files changed, 14 insertions(+), 19 deletions(-) ^Triage: committed and MFCed back in 2021. |