Bug 217533

Summary:

[PATCH] re-do process to pick up (possibly) redefined $rc_conf_files

Product:

Base System

Reporter:

Vinícius Zavam <egypcio>

Component:

conf

Assignee:

freebsd-rc (Nobody) <rc>

Status:

Closed FIXED

Severity:

Affects Some People

Keywords:

patch

Priority:

---

Version:

10.3-RELEASE

Hardware:

Any

OS:

Any

URL:

https://reviews.freebsd.org/D12568

Attachments:

Description	Flags
[PATCH] redefined $rc_conf_files? check it again.	none

Description Vinícius Zavam freebsd_committer

2017-03-04 13:13:41 UTC

Created attachment 180491 [details]
[PATCH] redefined $rc_conf_files? check it again.

Based on r302149 (releng/11.0), D6895, I suggest a merge into /etc/defaults/rc.conf to check redefined $rc_conf_files.

Attached patch solves releng/10.3, but ignores the extra addition of "vendor.conf". From https://svnweb.freebsd.org/base/release/11.0.1/etc/defaults/rc.conf?revision=306421

Working scenario considering this patch can be checked at https://github.com/egypcio/freebsd-digitalocean (custom/voluntary implementation of DigitalOcean's rc Script for FreeBSD).

Comment 1 Vinícius Zavam freebsd_committer

2017-04-28 12:44:46 UTC

The patch still needs to be applied,
  and works well on 10.3-RELEASE-p18.

Any feedback is appreciated. Thanks!

Comment 2 Vinícius Zavam freebsd_committer

2017-10-02 15:25:40 UTC

# ident etc/defaults/rc.conf
etc/defaults/rc.conf:
     $FreeBSD: releng/10.3/etc/defaults/rc.conf 295461 2016-02-10 07:16:17Z cy $

# patch -p0 < /root/BASE_r306421_etc_defaults_rc.conf_PATCH 
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|--- /etc/defaults/rc.conf      2016-03-25 02:11:14.000000000 +0000
|+++ etc/defaults/rc.conf       2017-03-03 16:52:52.379856000 +0000
--------------------------
Patching file etc/defaults/rc.conf using Plan A...
Hunk #1 succeeded at 722.
done

Comment 3 Vinícius Zavam freebsd_committer

2017-10-02 15:33:32 UTC

root@pizza-hog:~/freebsd/releng/10.4 # ident etc/defaults/rc.conf
etc/defaults/rc.conf:
     $FreeBSD: releng/10.4/etc/defaults/rc.conf 301818 2016-06-11 01:34:41Z ngie $

root@pizza-hog:~/freebsd/releng/10.4 # patch -p0 < /root/BASE_r306421_etc_defaults_rc.conf_PATCH
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|--- /etc/defaults/rc.conf      2016-03-25 02:11:14.000000000 +0000
|+++ etc/defaults/rc.conf       2017-03-03 16:52:52.379856000 +0000
--------------------------
Patching file etc/defaults/rc.conf using Plan A...
Hunk #1 succeeded at 723 (offset 1 line).
done

Comment 4 Vinícius Zavam freebsd_committer

2017-10-17 07:58:11 UTC

Approved by dteske@ and allanjude@ (https://reviews.freebsd.org/D12568).