Bug 217548

Summary: [PATCH] security/scrypt: Update to 1.2.1
Product: Ports & Packages Reporter: Raphael Kubo da Costa <rakuco>
Component: Individual Port(s)Assignee: Colin Percival <cperciva>
Status: Closed FIXED    
Severity: Affects Only Me CC: cperciva
Priority: --- Keywords: patch
Version: LatestFlags: bugzilla: maintainer-feedback? (cperciva)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Proposed patch none

Description Raphael Kubo da Costa freebsd_committer freebsd_triage 2017-03-04 22:40:42 UTC
Created attachment 180514 [details]
Proposed patch

Drop USES=gmake, the port built fine with make(1) on 10.3 and HEAD, switch from USE_OPENSSL=yes to USES=ssl.
Comment 1 Colin Percival freebsd_committer freebsd_triage 2017-03-05 07:19:33 UTC
I've got a very nasty cold right now so I won't be able to look at this properly for a few days.  One quick question though -- did make(1) change at some point to become compatible with automake, or vice versa?  I was sure I had found that gmake was necessary at some point...
Comment 2 Raphael Kubo da Costa freebsd_committer freebsd_triage 2017-03-05 09:51:24 UTC
(In reply to Colin Percival from comment #1)
> One quick question though -- did make(1) change at
> some point to become compatible with automake, or vice versa?  I was sure I
> had found that gmake was necessary at some point...

I tried building 1.2.0 with make(1) and it worked on both 10.3 and HEAD. Are you sure it wasn't necessary only on 9.x because of its old make?
Comment 3 Raphael Kubo da Costa freebsd_committer freebsd_triage 2017-03-26 15:38:20 UTC
ping?
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-04-12 20:49:25 UTC
A commit references this bug:

Author: cperciva
Date: Wed Apr 12 20:48:28 UTC 2017
New revision: 438412
URL: https://svnweb.freebsd.org/changeset/ports/438412

Log:
  Update security/scrypt to version 1.2.1.

  Add LICENSE.

  Remove USES=gmake; I have no idea why I put it there in the first place,
  but it is clearly not necessary now.

  PR:		217548
  Submitted by:	Raphael Kubo da Costa

Changes:
  head/security/scrypt/Makefile
  head/security/scrypt/distinfo
Comment 5 Colin Percival freebsd_committer freebsd_triage 2017-04-12 20:56:16 UTC
Sorry about taking so long to deal with this.  It's in the tree now.