Bug 217565
| Summary: | [patch] net/wpa_gui: add Qt5 / NLS options | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Andriy Voskoboinyk <avos> | ||||||||
| Component: | Individual Port(s) | Assignee: | Joseph Mingrone <jrm> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | jrm | ||||||||
| Priority: | --- | Keywords: | patch | ||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 180543 [details]
Poudriere logs (10.3-RELEASE i386, 11.0-RELEASE amd64)
(warnings about libGL are wrong and should go away when compiled with LDFLAGS=-Wl,--as-needed + non-broken compiler (clang ignores this option))
Created attachment 191116 [details]
patch to default to Qt5 and other tweaks
Sorry to see this has not been addressed for so long. Since Qt4 is no longer supported upstream, what do you think about just defaulting to Qt5? The attached patch does that (tested) and includes some other tweaks to conform to the 'Order of Variables in Port Makefiles' chapter in the Porter's Handbook. A commit references this bug: Author: jrm Date: Wed Jun 13 19:25:37 UTC 2018 New revision: 472340 URL: https://svnweb.freebsd.org/changeset/ports/472340 Log: net/wpa_gui: Switch to QT5, add NLS option, cleanup PR: 217565 Submitted by: avos (in part) Changes: head/net/wpa_gui/Makefile |
Created attachment 180542 [details] Makefile.diff - Provide a choice between Qt4 and Qt5 (Qt4 is selected by default). - Add NLS option (only one localization is installed at the moment). - Drop suid bit (Qt5 binary will not run with it + wpa_gui(8) seems to work fine even without it (checked with base wpa_supplicant(8))) - Bump PORTREVISION.