Bug 217697
| Summary: | databases/gtksql: Fix build (v0.4.5) | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | lightside <lightside> |
| Component: | Individual Port(s) | Assignee: | Kirill Ponomarev <krion> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | krion |
| Priority: | --- | Keywords: | patch |
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
| Attachments: | |||
Comment on attachment 180716 [details] Proposed patch (since 428908 revision) Proposed patch also works with x11-toolkits/scintilla update in bug 217693. Created attachment 180720 [details]
Proposed patch (since 428908 revision)
Paraphrase some comment.
Created attachment 180722 [details]
Proposed patch (since 428908 revision)
Created attachment 180731 [details]
Proposed patch (since 428908 revision)
Added correct patch.
Created attachment 180739 [details]
Proposed patch (since 428908 revision)
Added sed patch to fix following compiler's warning, just in case:
-8<--
gtksql_query_scintilla.c:131:17: warning: implicitly declaring library function 'malloc' with type
'void *(unsigned long)'
tr.lpstrText = malloc((tr.chrg.cpMax - tr.chrg.cpMin) * 2);
^
gtksql_query_scintilla.c:131:17: note: please include the header <stdlib.h> or explicitly provide a declaration for
'malloc'
-->8-
Created attachment 180761 [details]
Proposed patch (since 428908 revision)
Simplified sed patch a bit.
A commit references this bug: Author: krion Date: Mon Mar 13 18:17:04 UTC 2017 New revision: 436103 URL: https://svnweb.freebsd.org/changeset/ports/436103 Log: - Fix build - Add new necessary dependencies - Replace portions of CPPFLAGS and LDFLAGS with sed patches for ${WRKSRC}/configure - Add sed patch to rename some deprecated structure names after v3.7.1 update of x11-toolkits/scintilla PR: 217697 Submitted by: lightside@gmx.com Approved by: mat (mentor) Differential Revision: https://reviews.freebsd.org/D9974 Changes: head/databases/gtksql/Makefile head/databases/gtksql/files/patch-Makefile.in head/databases/gtksql/files/patch-po__Makefile.in.in |
Created attachment 180716 [details] Proposed patch (since 428908 revision) Patch to fix build of databases/gtksql port after x11-toolkits/scintilla update to v3.7.1. - Bump PORTREVISION - Add dependencies, which was found by stage-qa - Add localbase to USES - Replace portions of CPPFLAGS and LDFLAGS with sed patches for ${WRKSRC}/configure - Add sed patch to rename some deprecated structure names after v3.7.1 update of x11-toolkits/scintilla - Regenerate patches in files directory The build was tested for FreeBSD 10.3 amd64 (native and with using poudriere; default options).