Bug 21771

Summary:

Fix for sppp and Cronyx drivers update

Product:

Base System

Reporter:

rik <rik>

Component:

kern

Assignee:

Roman Kurakin <rik>

Status:

Closed FIXED

Severity:

Affects Only Me

Priority:

Normal

Version:

4.1-RELEASE

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
cronyx_patch.tgz	none
sppp1.pch	none

Description rik 2000-10-05 16:50:00 UTC

	Numerous fixes for sppp driver to make it workable in real life
	situations. It also contains patch with Frame Relay.
	Drivers update consists of update for Cronyx-Sigma adapter (cx) and
	two new drivers Cronyx-Tau (ct) and Cronyx-TauPCI (cp, taupci).
	If it is possible, we would like to submit the part of the TauPCI 
	driver as the object file (containing the low level hardware 
	handling routings). We knew about NETGRAPH and we support it, 
	but many of users, better to say most of them, who uses our 
	equipment still prefer sppp, so we would like to see all our 
	changes for sppp in main tree. Moreover all our drivers hardly 
	depend on these changes. We made patch keeping in mind that these
	changes should be transparent for all other drivers and we think
	we succeed in it. Because this patch is quite big (about 1M), if
	needed, we could split it in to logical pieces in order they
	should be applied.

Comment 1 rik 2000-10-09 15:23:26 UTC

Hi,
	I just find out that my reply address is incorrect. Please,
correct my reply address in database - rik@cronyx.ru

Thanks,
	      Kurakin Roman

Comment 2 rik 2001-10-27 15:16:22 UTC

-------- Original Message --------
Subject: kern/11238, kern/14848, kern/21771, sppp patch's patch_id #1
Date: Sat, 27 Oct 2001 18:06:51 +0400
From: Roman Kurakin <rik@cronyx.ru>
To: freebsd-net@FreeBSD.org
CC: Serge Vakulenko <vak@cronyx.ru>, mike@FreeBSD.org, 
freebsd-bugs@FreeBSD.org, julian@FreeBSD.org, archie@FreeBSD.org, 
joerg@FreeBSD.org, rik@cronyx.ru
References: <000901c1134b$827a69a0$48b5ce90@crox>



Hi,
   
    This is the first patch of set of patches that I plan to make. These 
patches ware send several
times as a big patch and last one wasn't even discussed. So I will try 
to send them by small
pieces and will try to comment them.

    Last one big patch was kern/21771. Last our version of sppp and 
adapter drivers could be found
at http://www.cronyx.ru/software/

    First portion contains following changes:
1) Just a header changes.
2) Changes like that:
                case STATE_CLOSING:
-                       sppp_cp_change_state(cp, sp, STATE_CLOSED);
                        (cp->tlf)(sp);
+                       sppp_cp_change_state(cp, sp, STATE_CLOSED);
                        break;

Comment:

    If you change state at first and then call tlf you will get wrong 
final state cause tlf will
lead to "Close" event and you will get (for this example) final state 
"Initial".

    In some cases this isn't so fatal but in other this will put out of 
action a link.

    All this changes was made according to RFC1661.

Best regards,

Roman Kurakin, Software Engineer,
Cronyx Engineering

>>Synopsis: Frame Relay support, corrected
>>
>>State-Changed-From-To: open->suspended
>>State-Changed-By: mike
>>State-Changed-When: Fri Jul 20 19:54:47 PDT 2001
>>State-Changed-Why: 
>>
>>With a little bit of work, this could probably be committed.
>>Awaiting committer.
>>
>>http://www.FreeBSD.org/cgi/query-pr.cgi?pr=14848
>>
>

Comment 3 Murray Stokely freebsd_committer

2001-11-28 19:47:26 UTC

Responsible Changed
From-To: freebsd-bugs->murray

I have hardware and have been in contact with the Cronyx folks.  I will work on this and import their working code to -CURRENT soon.

Comment 4 Maxim Konovalov freebsd_committer

2004-07-17 21:17:17 UTC

Responsible Changed
From-To: murray->rik

Roman is a committer now.

Comment 5 Roman Kurakin freebsd_committer

2005-07-05 12:58:18 UTC

State Changed
From-To: open->closed

Commited.