Bug 217742

Summary: sys/dev/isci/scil/scif_sas_controller.c: PVS-Studio: Expression is Always False (CWE-570)
Product: Base System Reporter: Svyatoslav <razmyslov>
Component: kernAssignee: freebsd-scsi (Nobody) <scsi>
Status: Closed FIXED    
Severity: Affects Many People CC: cem, jimharris, scottl
Priority: --- Keywords: patch
Version: CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
git patch none

Description Svyatoslav 2017-03-13 11:46:14 UTC 
Created attachment 180766 [details]
git patch

We have found and fixed a vulnerability using PVS-Studio tool. PVS-Studio is a static code analyzer for C, C++ and C#: https://www.viva64.com/en/pvs-studio/

Analyzer warning: V547 Expression is always false. scif_sas_controller.c 531
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-03-13 17:59:12 UTC 
A commit references this bug:

Author: cem
Date: Mon Mar 13 17:58:08 UTC 2017
New revision: 315205
URL: https://svnweb.freebsd.org/changeset/base/315205

Log:
  scif_sas_controller: Fix inverted logic range check

  PR:		217742
  Submitted by:	Svyatoslav <razmyslov at viva64.com>
  Sponsored by:	Viva64 (PVS-Studio)

Changes:
  head/sys/dev/isci/scil/scif_sas_controller.c
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-05-09 11:11:17 UTC 
A commit references this bug:

Author: dim
Date: Sat May  9 11:10:45 UTC 2020
New revision: 360842
URL: https://svnweb.freebsd.org/changeset/base/360842

Log:
  MFC r315205 (by cem):

  scif_sas_controller: Fix inverted logic range check

  PR:		217742
  Submitted by:	Svyatoslav <razmyslov at viva64.com>
  Sponsored by:	Viva64 (PVS-Studio)

Changes:
_U  stable/11/
  stable/11/sys/dev/isci/scil/scif_sas_controller.c