Bug 217749

Summary: sys/netinet/libalias/alias_proxy.c: PVS-Studio: Assignment to Variable without Use (CWE-563) (2)
Product: Base System Reporter: Svyatoslav <razmyslov>
Component: kernAssignee: freebsd-net (Nobody) <net>
Status: Closed FIXED    
Severity: Affects Many People CC: cem
Priority: --- Keywords: patch
Version: CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
git patch none

Description Svyatoslav 2017-03-13 12:18:13 UTC 
Created attachment 180772 [details]
git patch

We have found and fixed a vulnerability using PVS-Studio tool. PVS-Studio is a static code analyzer for C, C++ and C#: https://www.viva64.com/en/pvs-studio/

Analyzer warning: V519 The 'ret' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 722, 723. alias_proxy.c 723
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-03-13 18:06:22 UTC 
A commit references this bug:

Author: cem
Date: Mon Mar 13 18:05:32 UTC 2017
New revision: 315207
URL: https://svnweb.freebsd.org/changeset/base/315207

Log:
  alias_proxy.c: Fix accidental error quashing

  This was introduced on accident in r165243, when return sites were unified
  to add a lock around LibAliasProxyRule().

  PR:		217749
  Submitted by:	Svyatoslav <razmyslov at viva64.com>
  Sponsored by:	Viva64 (PVS-Studio)

Changes:
  head/sys/netinet/libalias/alias_proxy.c