Bug 217817

Summary: [PATCH] devel/arduino: fix DOS2UNIX_REGEX, update atmega644 boards.txt patch
Product: Ports & Packages Reporter: Craig Leres <leres>
Component: Individual Port(s)Assignee: Carlos J. Puga Medina <cpm>
Status: Closed FIXED    
Severity: Affects Only Me CC: cpm
Priority: --- Keywords: patch, patch-ready
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch leres: maintainer-approval+

Description Craig Leres freebsd_committer freebsd_triage 2017-03-15 18:14:30 UTC
Many installed source files had CRLF line endings. This was due to too much escaping in DOS2UNIX_REGEX. Reduce the list of extensions to just the ones that need it and add (lower case) makefile.

Update optional 644 boards.txt patch to be like the atmega328 version: Only add one board called atmega644 with the mcu set to atmega644p.
Comment 1 Craig Leres freebsd_committer freebsd_triage 2017-03-15 18:16:09 UTC
Created attachment 180854 [details]
patch

(It sure would be nice if you could add an attachment when creating a bug and be able to select the patch checkbox and also set the maintainer-approval flag.)
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-03-18 00:31:03 UTC
A commit references this bug:

Author: cpm
Date: Sat Mar 18 00:30:08 UTC 2017
New revision: 436366
URL: https://svnweb.freebsd.org/changeset/ports/436366

Log:
  devel/arduino: fix DOS2UNIX_REGEX, update atmega644 boards patch

  - Many installed source files had CRLF line endings. This was due to too
    much escaping in DOS2UNIX_REGEX. Reduce the list of extensions to just
    the ones that need it and add (lower case) makefile.
  - Update optional 644 boards.txt patch to be like the atmega328 version.
    Only add one board called atmega644 with the mcu set to atmega644p.
  - Bump PORTREVISION

  PR:             217817
  Submitted by:   Craig Leres <leres@ee.lbl.gov> (maintainer)

Changes:
  head/devel/arduino/Makefile
  head/devel/arduino/files/extrapatch-hardware-arduino-boards.txt
Comment 3 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-03-18 00:31:56 UTC
Committed!

Thanks