Bug 217872
| Summary: | [NEW PORT] graphics/guetzli: Perceptual JPEG encoder | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Yuri Victorovich <yuri> | ||||||||
| Component: | Individual Port(s) | Assignee: | Tobias Kortkamp <tobik> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | tobik | ||||||||
| Priority: | --- | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Yuri Victorovich
2017-03-17 16:36:35 UTC
Created attachment 180907 [details]
shar archive
Hi Yuri, some comments inline. X# Created by: Yuri Victorovich <yuri@rawbw.com> X# $FreeBSD$ X XPORTNAME= guetzli XPORTVERSION= 0.170317 Version 1.0 is tagged on GitHub. Why can't we use it? XDISTVERSIONPREFIX= v DISTVERSIONPREFIX is unnecessary if you're not using the v1.0 tag. XCATEGORIES= graphics X XMAINTAINER= yuri@rawbw.com XCOMMENT= Perceptual JPEG encoder X XLICENSE= APACHE20 Missing LICENSE_FILE X XLIB_DEPENDS= libpng.so:graphics/png \ X libgflags_nothreads.so:devel/gflags X XUSE_GITHUB= yes XGH_ACCOUNT= google XGH_TAGNAME= b0cf821 X XUSES= gmake XCFLAGS+= -I${LOCALBASE}/include XLDFLAGS+= -L${LOCALBASE}/lib Remove CFLAGS and LDFLAGS and add USES=localbase:ldflags XPLIST_FILES= bin/guetzli X Xdo-install: X ${INSTALL_PROGRAM} ${WRKSRC}/bin/Release/guetzli ${STAGEDIR}${PREFIX}/bin X X.include <bsd.port.mk> The build seems to not be verbose. I suggest adding MAKE_FLAGS= verbose=1 to make future build failure logs more informative. This also reveals that -O3 is passed to the build where it shouldn't be. Maybe also add config=debug to MAKE_FLAGS. Created attachment 180944 [details]
shar archive
I corrected the problems.
(In reply to Yuri Victorovich from comment #3) You're still using a commit (4a18db3) after v1.0. Can you please tell me why? It's inevitable that this will come up when I submit the port for review. > You're still using a commit (4a18db3) after v1.0. Can you please tell me why?
Because they fixed compilation errors and didn't make a release with the fixes. This is to prevent creation of temporary patches.
Waiting for mentor approval: https://reviews.freebsd.org/D10074 A commit references this bug: Author: tobik Date: Tue Mar 21 21:03:49 UTC 2017 New revision: 436655 URL: https://svnweb.freebsd.org/changeset/ports/436655 Log: New port: graphics/guetzli Guetzli is a JPEG encoder that aims for excellent compression density at high visual quality. Guetzli-generated images are typically 20-30% smaller than images of equivalent quality generated by libjpeg. Guetzli generates only sequential (nonprogressive) JPEGs due to faster decompression speeds they offer. WWW: https://github.com/google/guetzli PR: 217872 Approved by: lme (mentor) Submitted by: Yuri Victorovich <yuri@rawbw.com> Differential Revision: https://reviews.freebsd.org/D10074 Changes: head/graphics/Makefile head/graphics/guetzli/ head/graphics/guetzli/Makefile head/graphics/guetzli/distinfo head/graphics/guetzli/files/ head/graphics/guetzli/files/patch-guetzli.make head/graphics/guetzli/pkg-descr (In reply to Yuri Victorovich from comment #5) I committed v1.0.1 which was very recently released. It should have all the necessary build fixes. Thanks! |