Bug 217898

Summary: [patch] mail/mutt general cleanup, enabling compressed folders by default
Product: Ports & Packages Reporter: Alex Kozlov <ak>
Component: Individual Port(s)Assignee: Alex Kozlov <ak>
Status: Closed FIXED    
Severity: Affects Only Me CC: dereks
Priority: --- Keywords: patch
Version: LatestFlags: dereks: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch-mutt.txt
none
patch-mutt2.txt none

Description Alex Kozlov freebsd_committer 2017-03-18 19:37:07 UTC
Created attachment 180937 [details]
patch-mutt.txt

General Makefile cleanup after update to 1.8.0, remove COMPRESSED_FOLDERS option, enabling it by default:

- Remove --disable-warnings, seems obsolete
- Remove unused plist variables: COMPRESSED_FOLDERS, XML
- Remove XML_NEEDED from COMPRESSED_FOLDERS, QUOTE_PATCH, SIDEBAR options.
  Only option that needs XML is NNTP
- Remove unused RR_PATCH_VERSION variable
- Make COMPRESSED_FOLDERS enabled by default. Its increases mutt binary size
  on negligible amount, not conflicts with anything and adds only one small
  example file.
Comment 1 Derek Schrock 2017-03-18 21:51:04 UTC
Can this patch also update GREETING_PATCH_VERSION to 1.8.0?
Comment 2 Alex Kozlov freebsd_committer 2017-03-18 22:24:24 UTC
Created attachment 180942 [details]
patch-mutt2.txt

Update greeting patch to 1.8.0
Comment 3 Derek Schrock 2017-03-18 22:56:08 UTC
Thanks.
Comment 4 commit-hook freebsd_committer 2017-03-18 23:17:29 UTC
A commit references this bug:

Author: ak
Date: Sat Mar 18 23:17:19 UTC 2017
New revision: 436452
URL: https://svnweb.freebsd.org/changeset/ports/436452

Log:
  - Remove --disable-warnings, obsolete
  - Remove unsused plist variables: COMPRESSED_FOLDERS, XML
  - Remove XML_NEEDED from COMPRESSED_FOLDERS, QUOTE_PATCH, SIDEBAR options.
    Only option that needs XML is NNTP
  - Remove unused RR_PATCH_VERSION variable
  - Update GREETING_PATCH to 1.8.0
  - Remove COMPRESSED_FOLDERS option and make this feature enabled by default.

  PR:	217898
  Approved by:	dereks@lifeofadishwasher.com (maintiner)

Changes:
  head/mail/mutt/Makefile
  head/mail/mutt/distinfo
  head/mail/mutt/pkg-plist