Bug 218015

Summary: devel/libpthread-stubs: Update to 0.4
Product: Ports & Packages Reporter: Matthew Rezny <rezny>
Component: Individual Port(s)Assignee: Ashish SHUKLA <ashish>
Status: Closed FIXED    
Severity: Affects Many People CC: 000.fbsd, freebsd
Priority: --- Flags: ashish: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
update libpthread-stubs to 0.4 and convert former lib consumers to build dependents rezny: maintainer-approval?

Description Matthew Rezny freebsd_committer freebsd_triage 2017-03-22 18:15:14 UTC
Created attachment 181066 [details]
update libpthread-stubs to 0.4 and convert former lib consumers to build dependents

Update libpthread-stubs to 0.4 which is now just a pkgconfig file, no stub library. Thus, it can only be a BUILD_DEPENDS now, not a LIB_DEPENDS. Change all consumers to have only a BUILD_DEPENDS on the pc file. Since the former consumers will be missing the library, all have received a PORTREVISION bump, except libdrm and Mesa ports as there are new revisions on the way.

libpthread-stubs, libdrm, libglapi, gbm, and libEGL have been tested. I do not have time to compile all other former consumers.
Comment 1 Ashish SHUKLA freebsd_committer freebsd_triage 2017-03-27 09:13:20 UTC
(In reply to Matthew Rezny from comment #0)

Hi,

Thanks for the diff. There is a typo in the diff:

Index: graphics/libglapi/Makefile
===================================================================
--- graphics/libglapi/Makefile  (revision 436707)
+++ graphics/libglapi/Makefile  (working copy)
@@ -10,7 +10,7 @@

 LICENSE=       MIT

-LIB_DEPENDS+=  libpthread-stubs.so:devel/libpthread-stubs
+BULID_DEPENDS+=        ${LOCALBASE}/libdata/pkgconfig/pthread-stubs.pc:devel/libpthread-stubs

 USE_XORG=      x11 xau xcb xdmcp xvmc


Apart from that, everything looks okay. I'm building this diff (along with couple of other affected ports), and will get back to you.

Ashish
Comment 2 Matthew Rezny freebsd_committer freebsd_triage 2017-03-27 15:52:23 UTC
(In reply to Ashish SHUKLA from comment #1)

Oops, that's even one I have built, but it wouldn't have been caught because the dependency was already present and that line does nothing when misspelled.
Comment 3 Ashish SHUKLA freebsd_committer freebsd_triage 2017-03-29 07:36:00 UTC
Committed, thanks!
Comment 4 Charles Lecklider 2017-03-29 10:45:11 UTC
I think you need to bump the version on x11/libxcb as things like Firefox, LibreOffice, and Sylpheed won't compile until that's rebuilt.
Comment 5 Matthew Rezny freebsd_committer freebsd_triage 2017-03-29 13:01:05 UTC
(In reply to Charles Lecklider from comment #4)

I missed that one when I searched for LIB_DEPENDS because it was a RUN_DEPENDS. Fix is on the way.
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-03-29 15:10:42 UTC
A commit references this bug:

Author: rezny
Date: Wed Mar 29 13:46:20 UTC 2017
New revision: 437202
URL: https://svnweb.freebsd.org/changeset/ports/437202

Log:
  Remove the no longer valid RUN_DEPENDS on libpthread-stubs

  PR:		218015
  Reported by:	freebsd@charles.lecklider.org
  Approved by:	swills (mentor)
  Differential Revision:	https://reviews.freebsd.org/D10182

Changes:
  head/x11/libxcb/Makefile
Comment 7 Miroslav Lachman 2017-03-29 17:38:35 UTC
Cannot build x11/libX11 with this https://reviews.freebsd.org/D10182 libxcb.

If I reverted libxcb to previous version of Makefile then x11/libX11 can be build.

I am using poudriere bulk and fresh ports tree. No local changes.

https://lists.freebsd.org/pipermail/freebsd-ports/2017-March/107935.html
Comment 8 commit-hook freebsd_committer freebsd_triage 2017-03-29 18:43:14 UTC
A commit references this bug:

Author: ashish
Date: Wed Mar 29 06:50:30 UTC 2017
New revision: 437182
URL: https://svnweb.freebsd.org/changeset/ports/437182

Log:
  - Update devel/libpthread-stubs to 0.4
  - Chase libpthread-stubs update, and also switch to BUILD_DEPENDS
    from LIB_DEPENDS, as port is now only .pc file

  PR:		218015
  Submitted by:	rezny

Changes:
  head/astro/viking/Makefile
  head/audio/py-karaoke/Makefile
  head/audio/xmms-curses/Makefile
  head/cad/brlcad/Makefile
  head/cad/openvsp/Makefile
  head/devel/libpthread-stubs/Makefile
  head/devel/libpthread-stubs/distinfo
  head/devel/libpthread-stubs/files/
  head/devel/libpthread-stubs/pkg-plist
  head/games/capicity/Makefile
  head/games/capitalism/Makefile
  head/games/spellathon/Makefile
  head/graphics/gbm/Makefile
  head/graphics/libEGL/Makefile
  head/graphics/libdrm/Makefile
  head/graphics/libglapi/Makefile
  head/graphics/libreatlas/Makefile
  head/net/x11vnc/Makefile
  head/science/massxpert/Makefile
  head/x11/slim/Makefile
  head/x11-wm/echinus/Makefile
Comment 9 commit-hook freebsd_committer freebsd_triage 2017-03-29 20:15:17 UTC
A commit references this bug:

Author: rezny
Date: Wed Mar 29 20:05:09 UTC 2017
New revision: 437228
URL: https://svnweb.freebsd.org/changeset/ports/437228

Log:
  Revert previous; in this one case there is a runtime dependency on
  pthread-stubs.pc because it is referenced in xcb.pc, which would be
  better handled as part of USE_XORG=xcb, but a quick fix is required.

  PR:		218015
  Approved by:	feld (mentor)

Changes:
  head/x11/libxcb/Makefile