Bug 21803

Summary:

[PATCH] wicontrol's -a option mis-documented and not implemented

Product:

Base System

Reporter:

brooks <brooks>

Component:

bin

Assignee:

Brooks Davis <brooks>

Status:

Closed FIXED

Severity:

Affects Only Me

CC:

wpaul

Priority:

Normal

Version:

5.0-CURRENT

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
file.diff	none

Description brooks 2000-10-07 01:00:00 UTC

The -a option (change access point density) is not implemented in
wicontrol.  The a flag was also temprorarily stolen for another purpose
and that usage is still documented in the manpage.

Fix: This patch removes documentation of the bogus -a option and implements
the other one.
How-To-Repeat: 
man wicontrol
wicontrol -i wi0 -a 2

Comment 1 Johan Karlsson freebsd_committer

2000-10-07 15:32:09 UTC

Responsible Changed
From-To: freebsd-bugs->wpaul

Over to wi maintainer.

Comment 2 brooks 2001-06-02 04:45:03 UTC

Below is an updated version of the patch that applies to a May 30th
current.

-- Brooks

Index: wicontrol.8
===================================================================
RCS file: /home/ncvs/src/usr.sbin/wicontrol/wicontrol.8,v
retrieving revision 1.21
diff -u -r1.21 wicontrol.8
--- wicontrol.8	2001/02/07 13:45:30	1.21
+++ wicontrol.8	2001/06/02 03:42:52
@@ -38,7 +38,7 @@
 .Nd configure WaveLAN/IEEE devices
 .Sh SYNOPSIS
 .Nm
-.Fl i Ar iface Op Fl oa
+.Fl i Ar iface Op Fl o
 .Nm
 .Fl i Ar iface Fl t Ar tx rate
 .Nm
@@ -106,7 +106,7 @@
 .Sh OPTIONS
 The options are as follows:
 .Bl -tag -width Fl
-.It Fl i Ar iface Op Fl oa
+.It Fl i Ar iface Op Fl o
 Display the current settings of the specified WaveLAN/IEEE interface.
 This retrieves the current card settings from the driver and prints them
 out.
@@ -114,12 +114,7 @@
 .Fl o
 flag will cause
 .Nm
-to print out the statistics counters instead of the card settings. Using
-the additional
-.Fl a
-flag will cause
-.Nm
-to print out encryption keys as ascii characters instead of in hex.
+to print out the statistics counters instead of the card settings.
 Encryption keys are only displayed if wicontrol is run as root.
 .It Fl i Ar iface Fl t Ar tx rate
 Set the transmit rate of the specified interface.
Index: wicontrol.c
===================================================================
RCS file: /home/ncvs/src/usr.sbin/wicontrol/wicontrol.c,v
retrieving revision 1.16
diff -u -r1.16 wicontrol.c
--- wicontrol.c	2001/01/09 00:50:45	1.16
+++ wicontrol.c	2001/06/02 03:41:28
@@ -715,7 +715,7 @@
 	opterr = 1;
 		
 	while((ch = getopt(argc, argv,
-	    "hoc:d:e:f:i:k:p:r:q:t:n:s:m:v:P:S:T:ZC")) != -1) {
+	    "a:hoc:d:e:f:i:k:p:r:q:t:n:s:m:v:P:S:T:ZC")) != -1) {
 		switch(ch) {
 		case 'Z':
 #ifdef WICACHE
@@ -795,6 +795,10 @@
 			break;
 		case 'P':
 			wi_setword(iface, WI_RID_PM_ENABLED, atoi(optarg));
+			exit(0);
+			break;
+		case 'a':
+			wi_setword(iface, WI_RID_SYSTEM_SCALE, atoi(optarg));
 			exit(0);
 			break;
 		case 'v':

-- 
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4

Comment 3 Brooks Davis freebsd_committer

2001-06-26 01:13:10 UTC

State Changed
From-To: open->closed

Comment 4 Brooks Davis freebsd_committer

2001-06-26 01:13:10 UTC

Responsible Changed
From-To: wpaul->brooks

Handle my own PR.