Bug 218121

Summary: multimedia/kodi: update to 17.1
Product: Ports & Packages Reporter: Mikael Urankar <mikael>
Component: Individual Port(s)Assignee: Carlos J. Puga Medina <cpm>
Status: Closed FIXED    
Severity: Affects Many People CC: cpm, mickael.maillot, swills
Priority: --- Keywords: patch, patch-ready
Version: LatestFlags: mickael.maillot: maintainer-feedback+
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218105
Bug Depends on: 216978    
Bug Blocks:    
Attachments:
Description Flags
patch
none
patch none

Description Mikael Urankar freebsd_committer freebsd_triage 2017-03-25 17:07:17 UTC
Created attachment 181193 [details]
patch

Update to kodi 17.1
add support for armv6 (raspberry pi 1 and pi2)
Comment 1 Mikael Urankar freebsd_committer freebsd_triage 2017-03-25 17:11:20 UTC
portlint -AC ok
poudriere testport ok
Comment 2 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-03-27 09:37:10 UTC
Take.
Comment 3 mickael.maillot 2017-03-27 15:04:35 UTC
Looks good to me, give me one day to test it on my HTPC.

Thanks for the incredible job !
Comment 4 Steve Wills freebsd_committer freebsd_triage 2017-03-27 17:50:26 UTC
Does this need an updated libcec? The dep on libcec might need to be updated.
Comment 5 Mikael Urankar freebsd_committer freebsd_triage 2017-03-27 18:07:26 UTC
It needs libcec-4 from bug #216978
Comment 6 Steve Wills freebsd_committer freebsd_triage 2017-03-28 02:16:21 UTC
(In reply to mikael.urankar from comment #5)
Ok, so the dependency needs to specify that. Also, I believe ports shouldn't modify DEFAULT_VERSION.
Comment 7 Mikael Urankar freebsd_committer freebsd_triage 2017-03-29 09:51:53 UTC
(In reply to Steve Wills from comment #6)

How can I use an openssl version from ports (the config script is doing 'pkg-config --exists --print-errors "openssl"') ?
with SSL_DEFAULT= openssl ?
There is nothing in the porters handbook.

I don't understand what I'm supposed to do with libcec. If you update it to 4.0.2 there will be no problem or do you plan to create multimedia/libcec4?
Comment 8 mickael.maillot 2017-03-30 15:10:43 UTC
Kodi 17.1 (witouth CEC option) works perfectly on my hardware.

We have to update libcec to 4.0.2 and kodi to 17.1 at the same time.
No need to keep an old libcec version since only kodi use it.
Comment 9 Steve Wills freebsd_committer freebsd_triage 2017-04-02 22:32:20 UTC
(In reply to mikael.urankar from comment #7)
We allow the user to pick which OpenSSL they use.

One of the supported options is the version from the base OS, which has things in /usr/ but doesn't have a .pc file. The configure script for kodi uses pkgconfig to find openssl, but since we don't have a .pc file for the one in base, that won't work if the user is using the version of OpenSSL from base.

Note tho that the configure script can also be told where to find OpenSSL via environment variables. So the solution at the moment is to add:

CONFIGURE_ENV=          OPENSSL_LIBS="-L${OPENSSLLIB}" OPENSSL_CFLAGS="-I${OPENSSLINC}"

to the port Makefile.

Perhaps at some point in the future the OpenSSL in base will have a .pc file and then all of the versions of OpenSSL that USES=ssl supports will be available via pkgconf.
Comment 10 Steve Wills freebsd_committer freebsd_triage 2017-04-02 22:38:22 UTC
(In reply to Steve Wills from comment #9)
Just to avoid confusing, reformatting that:


CONFIGURE_ENV=          OPENSSL_LIBS="-L${OPENSSLLIB}" \
                        OPENSSL_CFLAGS="-I${OPENSSLINC}"
Comment 11 Mikael Urankar freebsd_committer freebsd_triage 2017-04-03 17:38:39 UTC
Created attachment 181437 [details]
patch

new patch, use openssl from base
Comment 12 commit-hook freebsd_committer freebsd_triage 2017-04-03 22:35:51 UTC
A commit references this bug:

Author: cpm
Date: Mon Apr  3 22:35:13 UTC 2017
New revision: 437676
URL: https://svnweb.freebsd.org/changeset/ports/437676

Log:
  multimedia/kodi: update to 17.1

  - Add support for armv6 (RPi 1 and RPi 2)

  PR:		218121
  Submitted by:	Mikael Urankar <mikael.urankar@gmail.com>
  Reviewed by:	swills
  Approved by:	Mickael Maillot <mickael.maillot@gmail.com> (maintainer)

Changes:
  head/multimedia/kodi/Makefile
  head/multimedia/kodi/distinfo
  head/multimedia/kodi/files/patch-Makefile.in
  head/multimedia/kodi/files/patch-configure.ac
  head/multimedia/kodi/files/patch-m4_xbmc__arch.m4
  head/multimedia/kodi/files/patch-system_settings_rbp2.xml
  head/multimedia/kodi/files/patch-tools_depends_target_ffmpeg_FFmpeg-2.8.6-Jarvis-16.0_configure
  head/multimedia/kodi/files/patch-tools_depends_target_ffmpeg_FFmpeg-2.8.6-Jarvis-16.0_libavutil_x86_asm.h
  head/multimedia/kodi/files/patch-tools_depends_target_ffmpeg_FFmpeg-3.1.6-Krypton_configure
  head/multimedia/kodi/files/patch-tools_depends_target_ffmpeg_FFmpeg-3.1.6-Krypton_libavutil_x86_asm.h
  head/multimedia/kodi/files/patch-tools_depends_target_ffmpeg_autobuild.sh
  head/multimedia/kodi/files/patch-tools_depends_target_libdvdcss_Makefile
  head/multimedia/kodi/files/patch-tools_depends_target_libdvdnav_Makefile
  head/multimedia/kodi/files/patch-tools_depends_target_libdvdread_Makefile
  head/multimedia/kodi/files/patch-xbmc_core_VideoPlayer_Process_overrides_linux_ProcessInfoLinux.cpp
  head/multimedia/kodi/files/patch-xbmc_cores_AudioEngine_Sinks_AESinkOSS.cpp
  head/multimedia/kodi/files/patch-xbmc_cores_VideoPlayer_DVDDemuxSPU.cpp
  head/multimedia/kodi/files/patch-xbmc_cores_dvdplayer_DVDDemuxSPU.cpp
  head/multimedia/kodi/files/patch-xbmc_dialogs_GUIDialogGamepad.cpp
  head/multimedia/kodi/files/patch-xbmc_dialogs_GUIDialogNumeric.cpp
  head/multimedia/kodi/files/patch-xbmc_guilib_GUIAction.cpp
  head/multimedia/kodi/files/patch-xbmc_guilib_GUISpinControl.cpp
  head/multimedia/kodi/files/patch-xbmc_guilib_TextureBundleXBT.h
  head/multimedia/kodi/files/patch-xbmc_guilib_TextureBundleXPR.h
  head/multimedia/kodi/files/patch-xbmc_interfaces_builtins_GUIContainerBuiltins.cpp
  head/multimedia/kodi/files/patch-xbmc_interfaces_legacy_Dialog.cpp
  head/multimedia/kodi/files/patch-xbmc_linux_PlatformDefs.h
  head/multimedia/kodi/files/patch-xbmc_linux_XFileUtils.cpp
  head/multimedia/kodi/files/patch-xbmc_main_main.cpp
  head/multimedia/kodi/files/patch-xbmc_music_tags_MusicInfoTagLoaderCDDA.cpp
  head/multimedia/kodi/files/patch-xbmc_platform_posix_main.cpp
  head/multimedia/kodi/files/patch-xbmc_pvr_PVRActionListener.cpp
  head/multimedia/kodi/files/patch-xbmc_pvr_recordings_PVRRecording.cpp
  head/multimedia/kodi/files/patch-xbmc_storage_linux_DeviceKitDisksProvider.cpp
  head/multimedia/kodi/files/patch-xbmc_storage_linux_UDisksProvider.cpp
  head/multimedia/kodi/files/patch-xbmc_system.h
  head/multimedia/kodi/files/patch-xbmc_utils_CPUInfo.cpp
  head/multimedia/kodi/files/patch-xbmc_windowing_Makefile.in
  head/multimedia/kodi/files/patch-xbmc_windowing_WinEvents.cpp
  head/multimedia/kodi/files/patch-xbmc_windowing_WinEventsFreeBSD.cpp
  head/multimedia/kodi/files/patch-xbmc_windowing_WinEventsFreeBSD.h
  head/multimedia/kodi/files/patch-xbmc_windowing_WindowingFactory.h
  head/multimedia/kodi/files/patch-xbmc_windowing_egl_EGLNativeTypeAmlogic.cpp
  head/multimedia/kodi/files/patch-xbmc_windowing_es__scancodes.h
  head/multimedia/kodi/files/pkg-message.in
  head/multimedia/kodi/pkg-plist
Comment 13 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-04-03 22:43:27 UTC
Committed!

Thanks