Bug 218228

Summary: x11-toolkits/scintilla & editors/scite: Update to 3.7.4
Product: Ports & Packages Reporter: lightside <lightside>
Component: Individual Port(s)Assignee: Martin Wilke <miwi>
Status: Closed FIXED    
Severity: Affects Some People CC: cyberbotx, miwi
Priority: --- Keywords: patch
Version: LatestFlags: cyberbotx: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Proposed patch for x11-toolkits/scintilla (since 436016 revision)
cyberbotx: maintainer-approval+
Proposed patch for editors/scite (since 436016 revision)
cyberbotx: maintainer-approval+
Proposed patch for x11-toolkits/scintilla (since 437439 revision)
none
Proposed patch for editors/scite (since 437439 revision) none

Description lightside 2017-03-30 15:16:55 UTC
Created attachment 181314 [details]
Proposed patch for x11-toolkits/scintilla (since 436016 revision)

Patch to update x11-toolkits/scintilla and editors/scite ports from 3.7.3 to 3.7.4 version.

Look following link for changes:
http://www.scintilla.org/ScintillaHistory.html

The build was tested on FreeBSD 10.3 amd64.
Comment 1 lightside 2017-03-30 15:17:30 UTC
Created attachment 181315 [details]
Proposed patch for editors/scite (since 436016 revision)
Comment 2 Naram Qashat 2017-03-30 15:26:35 UTC
Patches are acceptable to me.
Comment 3 lightside 2017-05-03 13:48:14 UTC
Created attachment 182275 [details]
Proposed patch for x11-toolkits/scintilla (since 437439 revision)
Comment 4 lightside 2017-05-03 13:48:44 UTC
Created attachment 182276 [details]
Proposed patch for editors/scite (since 437439 revision)
Comment 5 lightside 2017-05-03 13:50:28 UTC
Looks like, the ports r437439 changes invalidated some portions of proposed patches (even if it was just a PORTREVISION bump in a new line):
-8<--
patch -C < scintilla.diff
...
Patching file scintilla/Makefile using Plan A...
Hunk #1 failed at 2.
1 out of 1 hunks failed while patching scintilla/Makefile
...
-->8-

I updated proposed patches because of this.
I guess, the maintainer-approval request(s) isn't required (again) for such simple additional changes.
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-05-06 06:00:38 UTC
A commit references this bug:

Author: miwi
Date: Sat May  6 06:00:24 UTC 2017
New revision: 440229
URL: https://svnweb.freebsd.org/changeset/ports/440229

Log:
  - Update to 3.7.4

  PR:		218228
  Submitted by:	lightside@gmx.com
  Approved by:	maintainer

Changes:
  head/editors/scite/Makefile
  head/editors/scite/distinfo
  head/x11-toolkits/scintilla/Makefile
  head/x11-toolkits/scintilla/distinfo