Bug 218294
| Summary: | net/shadowsocks-libev new version to 3.1.0 | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | xsan <yp2008cn> | ||||||||||||||
| Component: | Individual Port(s) | Assignee: | Guangyuan Yang <ygy> | ||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||
| Severity: | Affects Many People | CC: | adamw, emaste, miwi, rgrimes, xiaoding+freebsd, ygy, yp2008cn, zhoushuqun | ||||||||||||||
| Priority: | --- | Flags: | xiaoding+freebsd:
maintainer-feedback+
|
||||||||||||||
| Version: | Latest | ||||||||||||||||
| Hardware: | Any | ||||||||||||||||
| OS: | Any | ||||||||||||||||
| URL: | https://reviews.freebsd.org/D13099 | ||||||||||||||||
| Bug Depends on: | 223095 | ||||||||||||||||
| Bug Blocks: | |||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
xsan
2017-04-01 18:38:50 UTC
Created attachment 181389 [details]
shar file for ports.
Accepted. Thanks! Thanks! Hey, Please submit a diff instance of a shar. Thanks Created attachment 184755 [details]
Diff patch.
This is the diff patch file of this ports.
Created attachment 186858 [details]
diff to upgrade to 3.0.7 based on 2.4.7
Created attachment 186865 [details]
diff to upgrade to 3.1.0 based on 2.4.7
Looks like there is no hope to upgrade this port.. (In reply to xsan from comment #8) As per porter's handbook, if the maintainer does not respond to an update request after two weeks (excluding major public holidays), then that is considered a maintainer timeout, and the update may be made without explicit maintainer approval. (In reply to Sutra from comment #9) That is correct. I will test the patch and see if I could commit it. (In reply to Sutra from comment #7) `portlint -C` reports: WARN: Makefile: [23]: USE_* seen before USES. According to the porters-handbook, USES must appear first. Please update the patch to reflect this, thanks! Created attachment 187206 [details]
diff to upgrade to 3.1.0 based on 2.4.7
(In reply to Sutra from comment #12) TEST PLAN: portlint -C: Passed poudriere testport: - 11.1-RELEASE amd64: Passed http://poudriere.charlieyang.me/build.html?mastername=111Ramd64-development&build=2017-10-16_09h22m38s - 10.4-RELEASE i386: Passed http://poudriere.charlieyang.me/build.html?mastername=104Ri386-development&build=2017-10-16_09h32m46s There are some issues that need to be ironed out first, please.
${CP} shouldn't be used to put files into ${STAGEDIR}; it should be ${INSTALL_DATA} instead.
%%PORTDOCS%% is meaningless without a DOCS option (%%PORTDOCS%% expands based upon whether the DOCS option is enabled, but there's no options at all for this port).
asciidoc should almost never be a mandatory dependency, and it's huge enough that it should never be behind the DOCS option either.
Consider something like this instead:
Makefile:
OPTIONS_DEFINE= HTMLDOCS
OPTIONS_DEFAULT= HTMLDOCS
OPTIONS_SUB= yes
HTMLDOCS_BUILD_DEPENDS= asciidoc:... xmlto:...
HTMLDOCS_CONFIGURE_ENABLE= docs
(That equates to --enable-docs or --disable-docs, change it to be what the actual configure knob is)
pkg-plist:
%%HTMLDOCS%%%%DOCSDIR%%/foo/bar.html
Thanks Adam. @Sutra, do you still want to work on this patch? Also FYI, the maintainer is willing to give up the maintainership for anyone interested (in PR223095). Created attachment 187427 [details]
diff to upgrade to 3.1.0 based on 2.4.7
(In reply to Sutra from comment #16) Accepted with thanks! @Sutra, you can take the port maintainership if you will. I am afraid I may not have enough time in maintaining. (In reply to Sutra from comment #16) Here are some functional improvements we can make effort: * Add UDP flag. The new version comes with "-u" flag to support udp relay mode. We can add support in shadowsocks-libev rc script. * Support client mode. This port was intended to be a server side service providing access to remote clients. However, some desktop users also need the client side functionality. We can add "shadowsocks_libev_client_enable" variable to rc script to support. * Support multiple instances. Different instances with different ports/encryption methods is also very useful to some users. Thanks! (In reply to xiaoding+freebsd from comment #18) > * Add UDP flag. The new version comes with "-u" flag to support udp relay mode. We can add support in shadowsocks-libev rc script. The "-u" flag could be specified by the json format config file, using "mode": "tcp_and_udp". A commit references this bug: Author: ygy Date: Thu Nov 16 17:35:37 UTC 2017 New revision: 454320 URL: https://svnweb.freebsd.org/changeset/ports/454320 Log: net/shadowsocks-libev: Update to 3.1.0 PR: 218294 Submitted by: Anonymous Approved by: xiaoding+freebsd@xiaoding.org (maintainer), adamw Differential Revision: https://reviews.freebsd.org/D13099 Changes: head/net/shadowsocks-libev/Makefile head/net/shadowsocks-libev/distinfo head/net/shadowsocks-libev/pkg-plist |
