Bug 218370

Summary: net/socat: add READLINE option
Product: Ports & Packages Reporter: Po-Chuan Hsieh <sunpoet>
Component: Individual Port(s)Assignee: Emanuel Haupt <ehaupt>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (ehaupt)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch none

Description Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-04-04 14:27:38 UTC
Created attachment 181476 [details]
patch

Add READLINE option

- Bump PORTREVISION for dependency and package change

====> Running Q/A tests (stage-qa)
Error: /usr/local/bin/filan is linked to /usr/local/lib/libreadline.so.6 from devel/readline but it is not declared as a dependency
Warning: you need USES+=readline
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-04-10 09:48:08 UTC
A commit references this bug:

Author: ehaupt
Date: Mon Apr 10 09:47:24 UTC 2017
New revision: 438139
URL: https://svnweb.freebsd.org/changeset/ports/438139

Log:
  socat will automatically link against readline if devel/readline is installed.
  Make readline optional and explicitly enable/disable during configure. This
  did not affect pkg only users as readline is not present on package build
  clusters but might affect (depending on readline presence) users that manually
  build ports. Therefore bump PORTREVISION.

  PR:		218370 (based on)
  Submitted by:	sunpoet

Changes:
  head/net/socat/Makefile
Comment 2 Emanuel Haupt freebsd_committer freebsd_triage 2017-04-10 09:49:18 UTC
Committed with minor modifications, thanks!

Modifications:
configure needs to be told to disable readline if readline option is not selected otherwise it will still link against readline if present.