Bug 218405

Summary: emulators/simh: VAX Firmware Modified by dos2unix
Product: Ports & Packages Reporter: Brad Sliger <code>
Component: Individual Port(s)Assignee: Alex Kozlov <ak>
Status: Closed FIXED    
Severity: Affects Only Me CC: ak, bob
Priority: --- Flags: bob: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Proposed Patch none

Description Brad Sliger 2017-04-05 20:31:08 UTC 
It looks like the VAX firmware at VAX/ka655x.bin is modified by dos2unix so that the microvax simulator hangs on boot.

Simh has other binary-looking files that dos2unix may need to skip, like *.bmp and *.cur.  Adding the following line to the port's Makefile works around the firmware hang for me.  There are also *.bat, *.mms, and *.com text files, but they look like they're for use on other systems.

Thanks!

DOS2UNIX_GLOB= *.c *.h *.txt *.mak *.ini makefile
Comment 1 Bob Eager 2017-04-05 20:55:48 UTC 
You are absolutely right. This was added as a global change when the number of diffs increased dramatically, and it was a faulty sledgehammer.

Please add suggested fix with my approval, unless you want a new set of diffs.
Comment 2 Brad Sliger 2017-04-08 00:31:47 UTC 
Created attachment 181578 [details]
Proposed Patch
Comment 3 Bob Eager 2017-04-08 09:01:58 UTC 
Patch approved by maintainer.
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-04-10 10:27:44 UTC 
A commit references this bug:

Author: ak
Date: Mon Apr 10 10:26:50 UTC 2017
New revision: 438141
URL: https://svnweb.freebsd.org/changeset/ports/438141

Log:
  - Add a number of PDF files containing comprehensive documentation [1]
  - Add manual page [1]
  - Stop mangling binary files with dos2unix [2]

  PR:	218151 [1]
  PR:	218405 [2]

  Submitted by:	bob@eager.cx (maintainer) [1]
  Submitted by:	Brad Sliger <code@sliger.org> [2]
  Approved by:	bob@eager.cx (maintainer) [2]

Changes:
  head/emulators/simh/Makefile
  head/emulators/simh/distinfo
  head/emulators/simh/files/pkg-message.in
  head/emulators/simh/files/simh.1.in
  head/emulators/simh/pkg-descr
  head/emulators/simh/pkg-plist