Bug 218409

Summary: databases/rocksdb: update to 5.2.1, add rocksdb-lite support
Product: Ports & Packages Reporter: David Thiel <lx>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Only Me CC: zi
Priority: --- Flags: bugzilla: maintainer-feedback? (sunpoet)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Diff for rocksdb port
none
Diff creating rocksdb-lite port
none
Diff for rocksdb port (updated)
none
Diff for rocksdb-lite (updated)
none
Diff for rocksdb port (with bash dependency) none

Description David Thiel freebsd_committer freebsd_triage 2017-04-05 22:24:28 UTC
Created attachment 181519 [details]
Diff for rocksdb port

RocksDB in "lite" mode appears to be more performant than the default unless you're using FusionIO cards, and osquery currently requires lite mode. So that we can update osquery, I've added a rocksdb-lite slave port along with updating RocksDB to the most current version.
Comment 1 David Thiel freebsd_committer freebsd_triage 2017-04-05 22:25:02 UTC
Created attachment 181520 [details]
Diff creating rocksdb-lite port
Comment 2 David Thiel freebsd_committer freebsd_triage 2017-04-05 23:10:24 UTC
Noticed some problems with passing the new libname to the -lite port. Updated patch will be forthcoming.
Comment 3 David Thiel freebsd_committer freebsd_triage 2017-04-06 02:00:52 UTC
Created attachment 181527 [details]
Diff for rocksdb port (updated)
Comment 4 David Thiel freebsd_committer freebsd_triage 2017-04-06 02:01:40 UTC
Created attachment 181528 [details]
Diff for rocksdb-lite (updated)
Comment 5 David Thiel freebsd_committer freebsd_triage 2017-04-06 02:03:15 UTC
Updated diffs should be good.
Comment 6 Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-04-06 21:48:03 UTC
Did you test it in poudriere?
Comment 7 David Thiel freebsd_committer freebsd_triage 2017-04-07 04:31:04 UTC
I unfortunately don't have a machine with enough disk space for poudriere right now (it's dying at the linking stage), and am waiting on a new laptop. I tested it with port(1) in a fresh VM snapshot, but it looks like my "fresh" snapshot still had bash in it, so I missed that new dependency. :-/

I can probably provision a VPS tomorrow and give it a full poudriere run.
Comment 8 David Thiel freebsd_committer freebsd_triage 2017-04-08 00:55:08 UTC
Created attachment 181579 [details]
Diff for rocksdb port (with bash dependency)

Adding bash, both ports go through poudriere cleanly.
Comment 9 commit-hook freebsd_committer freebsd_triage 2017-04-18 19:39:31 UTC
A commit references this bug:

Author: sunpoet
Date: Tue Apr 18 19:38:18 UTC 2017
New revision: 438797
URL: https://svnweb.freebsd.org/changeset/ports/438797

Log:
  Add rocksdb-lite 5.2.1

  PR:		218409
  Submitted by:	lx

Changes:
  head/databases/Makefile
  head/databases/rocksdb-lite/
  head/databases/rocksdb-lite/Makefile
Comment 10 Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-04-18 19:41:23 UTC
Committed. Thanks!