Bug 218493
| Summary: | www/phalcon: update to 3.1.2, PHP 7.1 support and 32 bit build | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Franco Fichtner <franco> | ||||||
| Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | linpct | ||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(linpct) |
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
I would use the following in Makefile instead of an extra patch.
post-patch:
.if ${PHP_VER} >= 70 && ${PBITS} == 32
@${REINPLACE_CMD} -e 's| ZEPHIR_FASTCALL||' ${WRKSRC}/phalcon.zep.c
.endif
The PHP var check looks good, but I don't strongly favour replacing all ZEPHIR_FASTCALL occurrences in a C file per sed. An upstream issue exists for the build problem, but has been mostly unresponsive. So far, we don't even know why this is problematic for some parts but not others. We can do what you propose, but it will take a bit more QA to see that it works as expected (2-3 days)? Created attachment 181606 [details]
version two without patch file
Comment on attachment 181606 [details]
version two without patch file
Maintainer approved.
A commit references this bug: Author: sunpoet Date: Wed Apr 12 16:25:26 UTC 2017 New revision: 438382 URL: https://svnweb.freebsd.org/changeset/ports/438382 Log: Update to 3.1.2 Changes: https://github.com/phalcon/cphalcon/blob/master/CHANGELOG.md PR: 218493 Submitted by: Franco Fichtner <franco@opnsense.org> Approved by: Daniel Lin <linpct@gmail.com> (maintainer) Changes: head/www/phalcon/Makefile head/www/phalcon/distinfo head/www/phalcon/files/ Committed. Thanks! |
Created attachment 181600 [details] phalcon 3.1.2 update Tested on: amd64 with PHP 7.0 and 7.1, i386 with PHP 7.0 and PHP 7.1