Bug 218509

Summary: net-mgmt/snmptt: Modernize port
Product: Ports & Packages Reporter: Danilo G. Baio <dbaio>
Component: Individual Port(s)Assignee: Renato Botelho <garga>
Status: Closed FIXED    
Severity: Affects Only Me CC: garga, nistor
Priority: --- Flags: garga: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
snmptt.patch
none
snmptt-01.patch
none
snmptt_D10312.patch
dbaio: maintainer-approval+
snmptt_D10312_single.patch dbaio: maintainer-approval+

Description Danilo G. Baio freebsd_committer freebsd_triage 2017-04-09 15:34:44 UTC 
Created attachment 181617 [details]
snmptt.patch

Modernizing port, several improvements were done:
- Use options helpers;
- Create user/group and directories necessary;
- Remove unnecessary dependencies;
- Add newsyslog conf;
- Pet portlint;
  
[Q/A]

portlint: looks fine.

testport:
   poudriere i386|amd64 10.3-RELEASE-p17     (OK)
   poudriere i386|amd64 11.0-RELEASE-p8      (OK)
   poudriere i386|amd64 12.0-CURRENT r316479 (OK)

I also created a review: https://reviews.freebsd.org/D10312
Comment 1 nistor 2017-04-09 15:45:12 UTC 
Looks great, thanks!
Comment 2 Danilo G. Baio freebsd_committer freebsd_triage 2017-04-09 15:50:24 UTC 
Created attachment 181618 [details]
snmptt-01.patch
Comment 3 Danilo G. Baio freebsd_committer freebsd_triage 2017-04-09 15:50:59 UTC 
Updating pkg-plist... Thanks.
Comment 4 Danilo G. Baio freebsd_committer freebsd_triage 2017-04-10 10:16:32 UTC 
Comment on attachment 181618 [details]
snmptt-01.patch

It was asked some changes in the review... I will submit a new patch asap.
Comment 5 Danilo G. Baio freebsd_committer freebsd_triage 2017-04-12 15:54:54 UTC 
Created attachment 181723 [details]
snmptt_D10312.patch

New patch attached.

Could you check and approve this patch, please ?

Reviewed in https://reviews.freebsd.org/D10312
Comment 6 Danilo G. Baio freebsd_committer freebsd_triage 2017-04-12 16:48:54 UTC 
Comment on attachment 181723 [details]
snmptt_D10312.patch

Approved in the review. Thank you.
Comment 7 Danilo G. Baio freebsd_committer freebsd_triage 2017-04-17 23:38:30 UTC 
Created attachment 181859 [details]
snmptt_D10312_single.patch

Replacing patch with full context (54K) with a single one (6.5K)
No changes were made.
Comment 8 Renato Botelho freebsd_committer freebsd_triage 2017-04-24 10:24:34 UTC 
I'll take it
Comment 9 Renato Botelho freebsd_committer freebsd_triage 2017-04-25 12:56:36 UTC 
Approved by maintainer in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218509#c1
Comment 10 commit-hook freebsd_committer freebsd_triage 2017-04-25 13:10:46 UTC 
A commit references this bug:

Author: garga
Date: Tue Apr 25 13:10:31 UTC 2017
New revision: 439381
URL: https://svnweb.freebsd.org/changeset/ports/439381

Log:
  Modernizing port, several improvements were done:

  * Use options helpers
  * Create user/group
  * Create necessary directories
  * Remove unnecessary dependencies
  * Add newsyslog conf
  * Pet portlint
  * Bump PORTREVISION

  PR:		218509
  Submitted by:	Danilo G. Baio (dbaio) <dbaio@bsd.com.br>
  Approved by:	nistor@snickers.org (maintainer)
  Sponsored by:	Rubicon Communications (Netgate)
  Differential Revision:	https://reviews.freebsd.org/D10312

Changes:
  head/GIDs
  head/UIDs
  head/net-mgmt/snmptt/Makefile
  head/net-mgmt/snmptt/files/newsyslog-snmptt.conf
  head/net-mgmt/snmptt/files/snmptt.in
  head/net-mgmt/snmptt/pkg-plist