Bug 218515

Summary: [NEW PORT] devel/naken_asm: Assembler/disassembler multiple CPUs
Product: Ports & Packages Reporter: mike
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me CC: w.schwarzenfeld
Priority: --- Keywords: needs-qa
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
naken_asm new port shar file. none

Description mike 2017-04-09 23:43:17 UTC 
Created attachment 181623 [details]
naken_asm new port shar file.

Assembler / disassembler for 4004, 6502, 65816, 6809, 68HC08, 68000, 8051, ARM, AVR8, Cell BE, dsPIC, MIPS, MSP430, PIC14, PIC24, PIC32, Playstation 2 EE, PowerPC, Propeller, RISC-V, STM8, SuperFX, THUMB, TMS1000, TMS1100, TMS9900, Z80.

http://www.mikekohn.net/micro/naken_asm.php
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2018-09-11 12:48:25 UTC 
(In reply to mike from comment #0)
Hi,

thanks for your submission.  It has been ~1.5 years since the port
was submitted.  It has several issues at the moment.  Before I go
into details, could you please tell me if you are still interested
in maintaining this port?
Comment 2 mike 2018-09-20 13:48:25 UTC 
If you guys want to include it I'll maintain it, if not no big deal.  I thought it might be useful for others.

I'm actually curious what the issues are?
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2018-09-20 14:24:33 UTC 
(In reply to mike from comment #2)

XPORTVERSION=   2017.04.09
XDISTNAME=      naken_asm-2017-04-09

Remove both and set

DISTVERSION=	2017-04-09

instead.

Probably could use an update to the newest version too.

XPKGNAMEPREFIX= naken_asm-

This will result in a package name of naken_asm-naken_asm which
makes little sense.

X#RUN_DEPENDS=  libreadline.so:devel/readline

Useless (and also wrong) comment.

XGNU_CONFIGURE= yes

Port does not use an autotools generated configure script, so it
should be HAS_CONFIGURE instead.

configure seems to use bash so it looks like there is a missing
BUILD_DEPENDS for it here.

X       @mkdir -p ${STAGEDIR}${PREFIX}

mkdir -p should be ${MKDIR}, but it's also unnecessary here.  A
stage directory and prefix skeleton is already created from
/usr/ports/Templates/BSD.local.dist by the framework.

X       @cp ${WRKSRC}/naken_asm ${STAGEDIR}${PREFIX}/bin/

Never use cp in do-install.  Use one of the INSTALL_* macros, here
${INSTALL_PROGRAM}.  It'll make sure that the binaries have the right
permissions and that they are stripped.

XWWW: http://www.mikekohn.net/micro/naken_asm.php
X
X

Superfluous new lines at the end of pkg-descr.

X/usr/local/bin/naken_asm
X/usr/local/bin/naken_util

A two line pkg-plist should just be folded directly into PLIST_FILES
in the Makefile.  Also drop the /usr/local/ prefix here.  PREFIX can
be overridden by users and it's implied if the path is relative.

Other issues:

- Missing LICENSE and LICENSE_FILE
- The port does not respect CFLAGS and LDFLAGS as set by the framework/users
  https://www.freebsd.org/doc/en/books/porters-handbook/dads-cflags.html
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2018-10-05 09:56:16 UTC 
Ping.
Comment 5 mike 2018-10-05 13:03:43 UTC 
I have this on my list of things to do this weekend.  Hope to have it cleaned up for Monday.
Comment 6 Tobias Kortkamp freebsd_committer freebsd_triage 2018-10-12 12:30:07 UTC 
I'm out.
Comment 7 mike 2018-10-12 12:58:58 UTC 
I understand. I'll close it.