Bug 218548
| Summary: | audio/cmus: Broken interface after oudate to 2.8.0-rc0 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Oleh Hushchenkov <o.hushchenkov> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Tobias Kortkamp <tobik> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Some People | Flags: | tobik:
maintainer-feedback+
|
||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| URL: | https://reviews.freebsd.org/D10355 | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 181663 [details]
Screenshot cmus 2.7.1
Created attachment 181675 [details]
cmus.diff
This is a lot trickier than I thought. I don't know why I didn't see
it before. What I think is happening is that cmus picks up
/usr/include/curses.h which has different definitions than
devel/ncurses which leads to the garbage we see. But it's hard to
tell for sure.
I came up with a patch that fixes the issue on my system. Can you
test please?
Created attachment 181676 [details]
cmus.diff
Small update. The configure script patch isn't necessary.
Hi Tobias. Thanks for your work on this. Patch fixed issue for me. Best regards. (In reply to Oleg Gushchenkov from comment #4) Thanks for testing so quickly. I'll commit this ASAP. A commit references this bug: Author: tobik Date: Tue Apr 11 14:04:38 UTC 2017 New revision: 438262 URL: https://svnweb.freebsd.org/changeset/ports/438262 Log: Fix broken UI when linking with devel/ncurses ports r438165 fixed building cmus with devel/ncurses installed, but stripped NCURSES_CFLAGS too aggressivly. The build picked up base's curses.h over the correct headers from devel/ncurses. PR: 218548 Reported by: Oleg Gushchenkov <gor@clogic.com.ua> Reviewed by: Oleg Gushchenkov <gor@clogic.com.ua> Approved by: mat (mentor) Differential Revision: https://reviews.freebsd.org/D10355 Changes: head/audio/cmus/Makefile |
Created attachment 181662 [details] Screenshot cmus 2.8.0-rc0 Update to 2.8.0-rc0 broke user interface. Cmus compiled with ncurses from ports.