Bug 218585

Summary:	www/firefox: fails to patch with SNDIO=on
Product:	Ports & Packages	Reporter:	Marco Beishuizen <mbeis>
Component:	Individual Port(s)	Assignee:	freebsd-gecko (Nobody) <gecko>
Status:	Closed FIXED
Severity:	Affects Some People	CC:	tobik
Priority:	---	Keywords:	patch, regression
Version:	Latest	Flags:	bugzilla: maintainer-feedback? (gecko)
Hardware:	Any
OS:	Any

Description Marco Beishuizen 2017-04-12 10:21:21 UTC

Applying patch on FF 53.0 fails with:
===> Fetching all distfiles required by firefox-53.0,1 for building
===>  Extracting for firefox-53.0,1
=> SHA256 Checksum OK for firefox-53.0.source.tar.xz.
===>  Patching for firefox-53.0,1
===>  Applying FreeBSD patches for firefox-53.0,1
No such line 323 in input file, ignoring
sed: /usr/ports/www/firefox/work/firefox-53.0/media/libcubeb/tests/moz.build: No such file or directory
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/www/firefox
*** Error code 1

Stop.
make: stopped in /usr/ports/www/firefox

Comment 1 Tobias Kortkamp freebsd_committer

2017-04-12 12:13:37 UTC

This is a problem when SNDIO=on.  Please try with this patch https://pkg.tobik.me/patches/bsd.gecko.mk.diff

Comment 2 commit-hook freebsd_committer

2017-04-12 17:21:36 UTC

A commit references this bug:

Author: jbeich
Date: Wed Apr 12 17:20:39 UTC 2017
New revision: 438394
URL: https://svnweb.freebsd.org/changeset/ports/438394

Log:
  www/firefox: unbreak SNDIO=on

  ===>  Applying FreeBSD patches for firefox-53.0,1
  No such line 323 in input file, ignoring
  sed: /usr/ports/www/firefox/work/firefox-53.0/media/libcubeb/tests/moz.build: No such fileor directory
  *** Error code 1

  PR:		218585
  Reported by:	jrm, Marco Beishuizen
  Submitted by:	tobik
  MFH:		2017Q2 (r438264 followup)

Changes:
  head/Mk/bsd.gecko.mk