Bug 218784
| Summary: | databases/rocksdb: remove no-op, fix LITE cflags | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | David Thiel <lx> | ||||
| Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | lx | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(sunpoet) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Also might want a PORTREVISION bump in addition, wasn't sure how you wanted to handle that, given the master/slave port situation. A commit references this bug: Author: sunpoet Date: Sun Apr 23 17:09:22 UTC 2017 New revision: 439242 URL: https://svnweb.freebsd.org/changeset/ports/439242 Log: Use CFLAGS instead of CPPFLAGS - Bump PORTREVISION for package change PR: 218784 Submitted by: lx Changes: head/databases/rocksdb/Makefile Committed. Thanks! |
Created attachment 181959 [details] Remove CPPFLAGS, change to CFLAGS After some functional testing, it looks like the current RocksDB isn't honoring CPPFLAGS. This makes the CPPFLAGS+= -DOS_FREEBSD a no-op, which is fine because cmake now defines that on its own. It also means that the CPPFLAGS+= -DROCKSDB_LITE=1 isn't getting honored. This diff removes the first CPPFLAGS line, and changes the latter one to use CFLAGS instead, which correctly builds the lite version (verified by checking the symbols). Both regular and -lite poudriere correctly.