Bug 218808
| Summary: | www/firefox: usr/bin/ld: error: unknown argument: --warn-unresolved-symbols (WITH_LLD_IS_LD) | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | O. Hartmann <ohartmann> |
| Component: | Individual Port(s) | Assignee: | freebsd-gecko (Nobody) <gecko> |
| Status: | Closed FIXED | ||
| Severity: | Affects Many People | CC: | emaste, toolchain |
| Priority: | --- | Flags: | jbeich:
maintainer-feedback+
|
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
| Bug Depends on: | |||
| Bug Blocks: | 214864 | ||
|
Description
O. Hartmann
2017-04-22 07:25:51 UTC
(In reply to O. Hartmann from comment #0) > I'm wondering about the error as it indicates a missing flag? Probably. Firefox uses --ignore-unresolved-symbol (ld.bfd 2.26+ or ld.gold 2.28+) or --warn-unresolved-symbol to allow environ(7) in shared libraries together with --no-undefined. This is a workaround for BSD libc, GNU libc is unaffected. $ cat a.c #include <stdio.h> void foo() { extern char **environ; for(int i = 0; environ[i] != NULL; i++) printf("%s\n", environ[i]); } $ cc -fPIC -shared -Wl,-z,defs -o a.so a.c -B/usr/local/bin -Wl,--ignore-unresolved-symbol,environ $ cc -fPIC -shared -Wl,-z,defs -o a.so a.c -Wl,--warn-unresolved-symbols /tmp/a-52cbc1.o: In function `foo': a.c:(.text+0x12): warning: undefined reference to `environ' a.c:(.text+0x32): warning: undefined reference to `environ' http://searchfox.org/mozilla-central/rev/6e1c138a06a8/old-configure.in#662 (In reply to Jan Beich from comment #1) > --ignore-unresolved-symbol (ld.bfd 2.26+ Oops, since ld.bfd 2.24 but the flag came from NetBSD. https://mail-index.netbsd.org/source-changes/2008/04/03/msg004439.html (In reply to Jan Beich from comment #2) Is there a solution? www/firefox doesn't build on 12-CURRENT (recent, as of today) anymore if WITH_LLD_IS_LD is enabled. poudriere also fails on the very same error. The recent update of www/firefox (at revision 441291) doesn't fix the reported problem, it still exists on traditional "make"-driven builds as well as in poudriere! The problem still persists in ports tree revision r443820 and prvents me from compiling www/firefox, which is now crashing rapidly on recent CURRENT (i.e. At revision 320065, amd64, with WITH_LLD_IS_LD=yes is set and the INO64 issue never resolved due to compilation problems). I consider this a serious issue since there are plans to make WITH_LLD_IS_LD the default on AMD64 platforms. Also, I stepped into another issue regarding devel/glib20 and I'd like to refer to Bug 220103 which seems to be related somehow having Jan Beichs comment (Comment 1) in mind. lld 5.0 per base r321369 does support --warn-unresolved-symbols, so comment 1 shows the following: /usr/bin/ld.lld: warning: undefined symbol: environ >>> referenced by a.c >>> /tmp/a-e9e734.o:(foo) /usr/bin/ld.lld: warning: undefined symbol: environ >>> referenced by a.c >>> /tmp/a-e9e734.o:(foo) Can you try building www/firefox on -CURRENT again? (In reply to Jan Beich from comment #6) I "solved" those problems for now by not usinf LLD as LD for the time being it is still harmful. Thanks. I'll keep this bug open just in case someone is searching for fallout of option WITH_LLD_IS_LS=yes. The problem seems to disappear when going the "GNU ld" path ... A commit references this bug: Author: jbeich Date: Thu Sep 28 19:32:05 UTC 2017 New revision: 450860 URL: https://svnweb.freebsd.org/changeset/ports/450860 Log: gecko: unbreak on 11.1 aarch64 /usr/bin/ld: error: unknown argument: --warn-unresolved-symbols PR: 218808 Reported by: O. Hartmann, pkg-fallout (for /head before lld 5.0 update) Changes: head/Mk/bsd.gecko.mk A commit references this bug: Author: jbeich Date: Fri Sep 29 12:51:15 UTC 2017 New revision: 450890 URL: https://svnweb.freebsd.org/changeset/ports/450890 Log: gecko: unbreak on 12.0 (lld by default) /usr/bin/ld: error: ../../js/src/jsarray.o: string table non-null terminated PR: 218808 Changes: head/Mk/bsd.gecko.mk |
