Bug 218851
| Summary: | [NEW PORT] devel/brotli: Brotli lossless compression libraries and commandline tool | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Markus Kohlmeyer <rootservice> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Many People | CC: | brnrd, i.dani, osa | ||||||||||||
| Priority: | --- | ||||||||||||||
| Version: | Latest | ||||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| URL: | https://github.com/google/brotli | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Markus Kohlmeyer
2017-04-24 15:39:15 UTC
Created attachment 182062 [details]
add devel/brotli to ports tree
Fixed CONFLICTS_INSTALL and typos
Hi Markus, thanks for the port. Would you mind to fix a couple of issues: 1. please add ability to build a static library too 2. please create the lib/libbrotlicommon.so.0 in addition to lib/libbrotlicommon.so lib/libbrotlicommon.so.0.6.0 Also, what's the reason to include pre and post mk files? .include <bsd.port.pre.mk> .include <bsd.port.post.mk> Would you mind to replace them with `.include <bsd.port.mk>' record? Thank you. Hi Sergey, thanks for your feedback, i'll fix your points in the next days. Created attachment 182096 [details]
add devel/brotli to ports tree
New patch with Sergeys suggestions.
There might be an upstream issue regarding building the static libs :(
I added the --disable-shared-libs option as proposed by upstream in the README, but that option does in fact do nothing.
As i'm not a programmer i'm a bit lost here, sorry.
It seems to me that the problem is in upstreams custom configure-cmake and/or the corresponding .configure-custom.sh file, but i can't figure out how to fix this.
The only reference to the lib_a i found is in the toplevel Makefile, but that is not used by cmake :(
Anything i can do?
Hi Markus, I'd recommend to talk to the vendor, i.e. raise an issue in https://github.com/google/brotli/issues for the same. Opened upsteam issue at https://github.com/google/brotli/issues/542 Created attachment 182113 [details]
add devel/brotli to ports tree
Updated patch with upstream workaround for the static building of libs and binary.
Upstream fix might be in the to be upcomming brotli-0.6.1 release.
Is there any chance to build both static and shared libraries? Basically a port from FreeBSD ports tree basically provides both types of libraries. Tag and Release date for Apache 2.4.26 is proposed/set to 06/12/2017, so this port should go in tree soon. https://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?r1=1798090&r2=1798089&pathrev=1798090 As for the parallel build of shared and static brotli-libs we have to wait for a future release of brotli because the Google-Dev(s) haven't provided this feature yet. Just created https://reviews.freebsd.org/D11290 to move devel/libbrotli to archivers/brotli. There seems to be no reason to keep both to me. Created attachment 183668 [details]
svn diff for archivers/brotli
For reference, the patch from the D11290 review
Thanks Bernard, the idea of moving/merging devel/libbrotli and archivers/brotli looks good for me. But that moving/merging doesn't address all parts of my proposed patch to add devel/brotli to the tree. Maybe you can merge yours and mine patches? (In reply to Markus Kohlmeyer from comment #12) Added the STATIC option to the review. Thanks for the pointer! I've not applied it in full, PORTREVISION?= 0 -> Only for master-ports GH_PROJECT= brotli -> defaults to PORTNAME USES= cmake:outsource compiler:c++0x localbase pathfix pkgconfig -> localbase is irrelevant, no brotli in base -> pathfix it builds fine for me without, am I missing something? BUILD_DEPENDS= bash:shells/bash -> Builds fine without bash, am I missing something? OPTIONS_DEFAULT= -> default is empty already STATIC_DESC= -> defined in Mk/bsd.options.desc.mk .if ${PORT_OPTIONS:MSTATIC} -> Convert to OPTIONS framework STATIC_CMAKE_ON= OPTIONS_SUB I see Sergey requested the .0 symlinks, not sure why... OK, then i'm fine with it, thanks. A commit references this bug: Author: brnrd Date: Wed Jul 12 19:44:57 UTC 2017 New revision: 445604 URL: https://svnweb.freebsd.org/changeset/ports/445604 Log: archivers/brotli: Move and update to 0.6.0 - Move from devel/libbrotli to archivers/brotli - Remove meta-project for library build - Bump epoch for meta 1.0 to upstream 0.6 update - Add MOVED entry - Switch from autoconf to cmake PR: 218813, 218851 Submitted by: Markus Kohlmeyer <rootservice@gmail.com> Approved by: maintainer time-out Differential Revision: https://reviews.freebsd.org/D11290 Changes: head/MOVED head/archivers/Makefile head/archivers/brotli/ head/archivers/brotli/Makefile head/archivers/brotli/distinfo head/archivers/brotli/files/ head/archivers/brotli/pkg-descr head/archivers/brotli/pkg-plist head/devel/Makefile head/devel/libbrotli/ |
