|Summary:||devel/valgrind devel/valgrind-devel: Properly detect clang 5.0.0|
|Product:||Ports & Packages||Reporter:||Dimitry Andric <dim>|
|Component:||Individual Port(s)||Assignee:||Bryan Drewery <bdrewery>|
|Severity:||Affects Some People||CC:||emaste|
|Bug Depends on:|
Description Dimitry Andric 2017-04-24 19:55:45 UTC
Created attachment 182055 [details] Fix clang 5 detection for valgrind I'm doing preliminary tests with clang 5.0.0 in the projects/clang500-import branch, and it turned out that devel/valgrind and devel/valgrind-devel fail to detect the version. This is because of a case statement with: clang-2.9|clang-3.*|clang-4.*) Here's a patch that adds clang-5.* for now (upstream might want to think about extending this to any correct numerical version). It also drops the USE_GCC from the Makefiles, which is apparently something added by Baptiste to support FreeBSD 8, so it is no longer necessary.
Comment 1 Bryan Drewery 2017-07-05 17:13:45 UTC
Approved, please commit
Comment 2 commit-hook 2017-07-05 17:21:47 UTC
A commit references this bug: Author: dim Date: Wed Jul 5 17:20:57 UTC 2017 New revision: 445087 URL: https://svnweb.freebsd.org/changeset/ports/445087 Log: Detect clang 5.0.0 correctly, and drop USE_GCC. Approved by: bdrewery (maintainer) PR: 218856 MFH: 2017Q3 Changes: head/devel/valgrind/files/patch-configure.ac head/devel/valgrind-devel/files/patch-configure.ac
Comment 3 Jan Beich 2017-07-05 18:25:48 UTC
USE_GCC hunk is missing from ports r445087, so the commit message is slightly confusing.
Comment 4 Dimitry Andric 2017-07-05 20:16:48 UTC
(In reply to Jan Beich from comment #3) > USE_GCC hunk is missing from ports r445087, so the commit message is > slightly confusing. Ah yeah sorry, that was already fixed in r440063 by bdrewery, some time ago. I had that in my tree for ages, so I was sort of convinced it still needed to be done. :)