Bug 219119

Summary: audio/sonic-visualiser: Use standard PULSEAUDIO option
Product: Ports & Packages Reporter: Tobias Kortkamp <tobik>
Component: Individual Port(s)Assignee: Tobias Kortkamp <tobik>
Status: Closed FIXED    
Severity: Affects Only Me CC: uddka
Priority: --- Keywords: patch
Version: LatestFlags: uddka: maintainer-feedback+
uddka: maintainer-feedback+
Hardware: Any   
OS: Any   
URL: https://reviews.freebsd.org/D10646
Attachments:
Description Flags
sonic-visualiser.diff uddka: maintainer-approval+

Description Tobias Kortkamp freebsd_committer freebsd_triage 2017-05-07 14:29:07 UTC 
The vast majority of ports name the option to enable PulseAudio support
PULSEAUDIO.  sonic-visualiser currently uses PULSE.  Can we change it to
PULSEAUDIO for consistencies sake?

This also makes it easier for users to disable/enable PulseAudio accross the
ports tree via OPTIONS_SET=PULSEAUDIO in /etc/make.conf without having to
remember to also set PULSE.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2017-05-07 14:29:45 UTC 
Created attachment 182361 [details]
sonic-visualiser.diff
Comment 2 Christian Krämer 2017-05-08 11:48:34 UTC 
Sounds reasonable...
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2017-05-08 14:16:39 UTC 
Thank you.
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-05-09 09:21:07 UTC 
A commit references this bug:

Author: tobik
Date: Tue May  9 09:19:26 UTC 2017
New revision: 440476
URL: https://svnweb.freebsd.org/changeset/ports/440476

Log:
  Rename option PULSE to PULSEAUDIO

  Almost all other ports use PULSEAUDIO to enable PulseAudio support.  This
  makes it easier to enable support globally via OPTIONS_SET.

  PR:		219119
  Approved by:	lme (mentor), Christian Kraemer <uddka@student.kit.edu> (maintainer)
  Differential Revision:	https://reviews.freebsd.org/D10646

Changes:
  head/audio/sonic-visualiser/Makefile